Issue 9569049: Gets rid of static analysis error in Context2Test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9569049: Gets rid of static analysis error in Context2Test (Closed)

Created:
8 years, 9 months ago by zundel

Modified:
8 years, 9 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Gets rid of static analysis error in Context2Test spoke with regis, and method not being defined was not important to the repro case. Committed: https://code.google.com/p/dart/source/detail?r=4913

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	tests/language/src/Context2Test.dart	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

regis

8 years, 9 months ago (2012-03-02 01:09:30 UTC) #2

LGTM

What is important is that the nested scopes and captured variables remain the
same. I verified that with the following command:
runtime/out/Debug_ia32/dart --print_scopes --print_ast
tests/language/src/Context2Test.dart

I then searched for the following line in the output and compared all scopes and
variables for both versions:
Annotated Scope for function
'/usr/local/google/home/regis/dart1/dart/tests/language/src/Context2Test.dart_V_hoop'
...

-- Regis

Expand Messages | Collapse Messages