Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 9569003: Add token to stderr as well as stdout for batch processing. (Closed)

Created:
8 years, 9 months ago by Mads Ager (google)
Modified:
8 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add token to stderr as well as stdout for batch processing. This makes it easy to tell when a test is completed and we have all the output. stderr and stdout are independent file descriptors so this is the only reliable way to know that you have flushed both. Committed: https://code.google.com/p/dart/source/detail?r=4782

Patch Set 1 #

Patch Set 2 : Don't revert status file change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -75 lines) Patch
M compiler/java/com/google/dart/compiler/UnitTestBatchRunner.java View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 9 chunks +69 lines, -75 lines 0 comments Download
M tools/testing/run_selenium.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
I reverted the previous change to fix this quickly. There were some cleanup changes that ...
8 years, 9 months ago (2012-03-01 08:41:16 UTC) #1
Jennifer Messerly
8 years, 9 months ago (2012-03-01 09:07:10 UTC) #2
lgtm. Nice to be waiting for stderr too :)

Powered by Google App Engine
This is Rietveld 408576698