Issue 9568016: Added test for issue 1882:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9568016: Added test for issue 1882: (Closed)

Created:
8 years, 9 months ago by Ivan Posva

Modified:
8 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/tests/

Visibility:
Public.

More Reviews

Description

Added test for issue 1882: - Make sure that we can disable library privacy for testing. Committed: https://code.google.com/p/dart/source/detail?r=4988

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -0 lines)			Patch
M	language/language.status	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	language/language-leg.status	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	language/src/DisablePrivacyLib.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A	language/src/DisablePrivacyTest.dart	View	1 chunk	+12 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

https://chromiumcodereview.appspot.com/9568016/diff/1/language/src/DisablePrivacyTest.dart File language/src/DisablePrivacyTest.dart (right): https://chromiumcodereview.appspot.com/9568016/diff/1/language/src/DisablePrivacyTest.dart#newcode4 language/src/DisablePrivacyTest.dart:4: // VMOptions=--disable_privacy I don't think we should have VM ...

8 years, 9 months ago (2012-03-08 19:10:43 UTC) #3

Siggi Cherem (dart-lang)

8 years, 9 months ago (2012-03-08 19:28:37 UTC) #4

https://chromiumcodereview.appspot.com/9568016/diff/1/language/src/DisablePri...
File language/src/DisablePrivacyTest.dart (right):

https://chromiumcodereview.appspot.com/9568016/diff/1/language/src/DisablePri...
language/src/DisablePrivacyTest.dart:4: // VMOptions=--disable_privacy
On 2012/03/08 19:10:44, ahe wrote:
> I don't think we should have VM specific options in the shared language test
> suite.

This might be a problem of how we specify the options for test.dart, but the
intention is that this should be an option that will be available also in
frog/leg, not just a vm option. See: http://dartbug.com/1882

Expand Messages | Collapse Messages