Do not allow native syntax on all libraries.

Do not allow native syntax on all libraries.
Committed: https://code.google.com/p/dart/source/detail?r=5070

[ngeoffray, 2012-03-01 13:05:25]

Added changes to status file.

[kasperl, 2012-03-01 13:05:57]

LGTM.

[ngeoffray, 2012-03-02 10:29:52]

Created a NativeHandler task to avoid the global state. PTAL

[ngeoffray, 2012-03-06 07:20:11]

Peter, any additional comments on this CL?

[ahe, 2012-03-06 08:12:44]

https://chromiumcodereview.appspot.com/9568008/diff/4001/dart/frog/leg/native...
File dart/frog/leg/native_handler.dart (right):

https://chromiumcodereview.appspot.com/9568008/diff/4001/dart/frog/leg/native...
dart/frog/leg/native_handler.dart:55: void checkAllowedLibrary(ElementListener
listener, Token token) {
Extracting the compiler from the ElementListener is problematic. I think this
will break mini_parser.

How about passing in a native handler to the ElementListener created in
dart/frog/leg/scanner/scanner_task.dart (assuming that all the following methods
are instance methods on the native handler).

[ngeoffray, 2012-03-06 12:48:48]

https://chromiumcodereview.appspot.com/9568008/diff/4001/dart/frog/leg/native...
File dart/frog/leg/native_handler.dart (right):

https://chromiumcodereview.appspot.com/9568008/diff/4001/dart/frog/leg/native...
dart/frog/leg/native_handler.dart:55: void checkAllowedLibrary(ElementListener
listener, Token token) {
On 2012/03/06 08:12:44, ahe wrote:
> Extracting the compiler from the ElementListener is problematic. I think this
> will break mini_parser.
> 
> How about passing in a native handler to the ElementListener created in
> dart/frog/leg/scanner/scanner_task.dart (assuming that all the following
methods
> are instance methods on the native handler).

Unfortunately, this does not work that well. See listener.dart line 1456. The
compiler is not available.

At this point, I'd rather do a "if (listener.listener is Compiler)".

[ahe, 2012-03-06 13:08:30]

https://chromiumcodereview.appspot.com/9568008/diff/4001/dart/frog/leg/native...
File dart/frog/leg/native_handler.dart (right):

https://chromiumcodereview.appspot.com/9568008/diff/4001/dart/frog/leg/native...
dart/frog/leg/native_handler.dart:55: void checkAllowedLibrary(ElementListener
listener, Token token) {
On 2012/03/06 12:48:49, ngeoffray wrote:
> On 2012/03/06 08:12:44, ahe wrote:
> > Extracting the compiler from the ElementListener is problematic. I think
this
> > will break mini_parser.
> > 
> > How about passing in a native handler to the ElementListener created in
> > dart/frog/leg/scanner/scanner_task.dart (assuming that all the following
> methods
> > are instance methods on the native handler).
> 
> Unfortunately, this does not work that well. See listener.dart line 1456. The
> compiler is not available.
> 
> At this point, I'd rather do a "if (listener.listener is Compiler)".

It will work fine. We can do a VC and I can explain what I mean.

[ngeoffray, 2012-03-07 09:26:06]

PTAL, with Peter we agreed on a third approach: putting a flag in the library
element to know whether that library has access to the native syntax.

[ahe, 2012-03-07 09:31:22]

LGTM!

https://chromiumcodereview.appspot.com/9568008/diff/13002/dart/frog/leg/nativ...
File dart/frog/leg/native_handler.dart (right):

https://chromiumcodereview.appspot.com/9568008/diff/13002/dart/frog/leg/nativ...
dart/frog/leg/native_handler.dart:34: void checkNativeSupport(Compiler compiler,
Rename to something like "maybeEnableNative"?

https://chromiumcodereview.appspot.com/9568008/diff/13002/dart/frog/leg/nativ...
dart/frog/leg/native_handler.dart:50: listener.unexpected(token);
Please use recoverableError.

[ngeoffray, 2012-03-07 09:35:08]

Thanks Peter!

https://chromiumcodereview.appspot.com/9568008/diff/13002/dart/frog/leg/nativ...
File dart/frog/leg/native_handler.dart (right):

https://chromiumcodereview.appspot.com/9568008/diff/13002/dart/frog/leg/nativ...
dart/frog/leg/native_handler.dart:34: void checkNativeSupport(Compiler compiler,
On 2012/03/07 09:31:23, ahe wrote:
> Rename to something like "maybeEnableNative"?

Done.

https://chromiumcodereview.appspot.com/9568008/diff/13002/dart/frog/leg/nativ...
dart/frog/leg/native_handler.dart:50: listener.unexpected(token);
On 2012/03/07 09:31:23, ahe wrote:
> Please use recoverableError.

Done.