Issue 9568006: Missing handling of default arguments in socket stream readInto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9568006: Missing handling of default arguments in socket stream readInto (Closed)

Created:
8 years, 9 months ago by Søren Gjesse

Modified:
8 years, 9 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Missing handling of default arguments in socket stream readInto Also made it a bit easier to write a socket connection test. R=ager@google.com BUG=dart:1925 TEST=tests/standalone/src/Regress-1925.dart Committed: https://code.google.com/p/dart/source/detail?r=4793

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+109 lines, -12 lines)			Patch
M	runtime/bin/socket_stream_impl.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/standalone/src/EchoServerStreamTest.dart	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	tests/standalone/src/EchoServerTest.dart	View	2 chunks	+1 line, -2 lines	0 comments	Download
A	tests/standalone/src/Regress-1925.dart	View	1 chunk	+70 lines, -0 lines	0 comments	Download
M	tests/standalone/src/SocketManyConnectionsTest.dart	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	tests/standalone/src/StreamPipeTest.dart	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	tests/standalone/src/TestingServer.dart	View	3 chunks	+33 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM