Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 9568004: Reapply dart:io API changes. (Closed)

Created:
8 years, 9 months ago by Mads Ager (google)
Modified:
8 years, 9 months ago
Reviewers:
Søren Gjesse, srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply dart:io API changes. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4790

Patch Set 1 #

Patch Set 2 : Add test binaries. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1169 lines, -1514 lines) Patch
M frog/leg/tools/mini_parser.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M frog/server/frog_server.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M frog/tests/frog/src/FrogServerTest.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/chunked_stream.dart View 4 chunks +10 lines, -10 lines 0 comments Download
M runtime/bin/directory.dart View 6 chunks +48 lines, -61 lines 0 comments Download
M runtime/bin/directory_impl.dart View 10 chunks +52 lines, -61 lines 0 comments Download
M runtime/bin/file.dart View 23 chunks +67 lines, -172 lines 0 comments Download
M runtime/bin/file_impl.dart View 48 chunks +147 lines, -253 lines 0 comments Download
M runtime/bin/http.dart View 4 chunks +14 lines, -14 lines 0 comments Download
M runtime/bin/http_impl.dart View 20 chunks +104 lines, -104 lines 0 comments Download
M runtime/bin/input_stream.dart View 4 chunks +13 lines, -13 lines 0 comments Download
M runtime/bin/list_stream_impl.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/bin/output_stream.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/bin/process.dart View 2 chunks +16 lines, -16 lines 0 comments Download
M runtime/bin/process_impl.dart View 9 chunks +21 lines, -22 lines 0 comments Download
M runtime/bin/socket.dart View 4 chunks +9 lines, -9 lines 2 comments Download
M runtime/bin/socket_impl.dart View 7 chunks +18 lines, -18 lines 0 comments Download
M runtime/bin/socket_stream_impl.dart View 7 chunks +24 lines, -24 lines 0 comments Download
M runtime/bin/stream_util.dart View 3 chunks +10 lines, -10 lines 0 comments Download
M runtime/bin/string_stream.dart View 4 chunks +13 lines, -13 lines 0 comments Download
M samples/chat/chat_server_lib.dart View 5 chunks +9 lines, -9 lines 0 comments Download
M samples/chat/chat_stress_client.dart View 4 chunks +16 lines, -16 lines 0 comments Download
M samples/tests/samples/src/chat/ChatServerTest.dart View 4 chunks +16 lines, -16 lines 0 comments Download
M samples/total/server/DartCompiler.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M samples/total/server/TotalRunner.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/src/ChunkedStreamTest.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/src/DartStdIOPipeTest.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M tests/standalone/src/DirectoryInvalidArgumentsTest.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/src/DirectoryTest.dart View 11 chunks +92 lines, -119 lines 0 comments Download
M tests/standalone/src/EchoServerStreamTest.dart View 5 chunks +8 lines, -8 lines 0 comments Download
M tests/standalone/src/EchoServerTest.dart View 6 chunks +11 lines, -11 lines 0 comments Download
M tests/standalone/src/FileInputStreamTest.dart View 5 chunks +8 lines, -8 lines 0 comments Download
M tests/standalone/src/FileInvalidArgumentsTest.dart View 8 chunks +33 lines, -41 lines 0 comments Download
M tests/standalone/src/FileOutputStreamTest.dart View 3 chunks +9 lines, -12 lines 0 comments Download
M tests/standalone/src/FileTest.dart View 27 chunks +204 lines, -276 lines 0 comments Download
M tests/standalone/src/HttpTest.dart View 11 chunks +20 lines, -20 lines 0 comments Download
M tests/standalone/src/ListInputStreamTest.dart View 13 chunks +32 lines, -32 lines 0 comments Download
M tests/standalone/src/ListOutputStreamTest.dart View 5 chunks +9 lines, -9 lines 0 comments Download
M tests/standalone/src/ProcessBrokenPipeTest.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/src/ProcessExitNegativeTest.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/src/ProcessExitTest.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/src/ProcessSegfaultTest.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/src/ProcessStartExceptionTest.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/src/ProcessStdIOScript.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/src/ProcessStderrTest.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/src/ProcessStdoutTest.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/src/ProcessWorkingDirectoryTest.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M tests/standalone/src/SocketCloseTest.dart View 4 chunks +9 lines, -9 lines 0 comments Download
M tests/standalone/src/SocketManyConnectionsTest.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/src/SocketStreamCloseTest.dart View 9 chunks +14 lines, -14 lines 0 comments Download
M tests/standalone/src/StreamPipeTest.dart View 7 chunks +10 lines, -10 lines 0 comments Download
M tests/standalone/src/StringStreamTest.dart View 5 chunks +7 lines, -7 lines 0 comments Download
M tests/standalone/src/TestingServer.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/testing/bin/linux/dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/testing/bin/macos/dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/testing/bin/windows/dart.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/testing/dart/status_file_parser.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 8 chunks +16 lines, -16 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 4 chunks +14 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
srdjan
https://chromiumcodereview.appspot.com/9568004/diff/1001/runtime/bin/socket.dart File runtime/bin/socket.dart (right): https://chromiumcodereview.appspot.com/9568004/diff/1001/runtime/bin/socket.dart#newcode21 runtime/bin/socket.dart:21: void set onError(void callback()); Can we pass argument to ...
8 years, 9 months ago (2012-03-01 18:08:07 UTC) #1
Søren Gjesse
8 years, 9 months ago (2012-03-01 20:26:42 UTC) #2
https://chromiumcodereview.appspot.com/9568004/diff/1001/runtime/bin/socket.dart
File runtime/bin/socket.dart (right):

https://chromiumcodereview.appspot.com/9568004/diff/1001/runtime/bin/socket.d...
runtime/bin/socket.dart:21: void set onError(void callback());
On 2012/03/01 18:08:07, srdjan wrote:
> Can we pass argument to the callback telling something about the error? How do
> we figure out what error occurred?

The error handling/reporting in dart:io is still something we need to work on.
It is on the OKRs for this quater. My suggestion is to have all the onError
callbacks receive an Exception object (probably SocketException here) which is
the exception that would have been thrown had the operation been synchronous.

Powered by Google App Engine
This is Rietveld 408576698