Issue 9567041: Implement prefixes in NewExpression.

Issue 9567041: Implement prefixes in NewExpression. (Closed)

Created:
8 years, 9 months ago by ahe

Modified:
8 years, 9 months ago

Reviewers:
karlklose, ngeoffray

CC:
reviews_dartlang.org, compiler-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement prefixes in NewExpression. Committed: https://code.google.com/p/dart/source/detail?r=5134

Patch Set 2 : Remove unrelated changes #

Patch Set 3 : Address comment #

Patch Set 4 : rebased #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -14 lines)			Patch
M	dart/frog/leg/resolver.dart	View	1 2 3	4 chunks	+14 lines, -6 lines	0 comments	Download
M	dart/frog/leg/tree/nodes.dart	View	1 2 3	1 chunk	+3 lines, -1 line	0 comments	Download
M	dart/tests/language/language-leg.status	View	1 2 3	5 chunks	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

Prefixes change LGTM! https://chromiumcodereview.appspot.com/9567041/diff/1/dart/frog/leg/compiler.dart File dart/frog/leg/compiler.dart (right): https://chromiumcodereview.appspot.com/9567041/diff/1/dart/frog/leg/compiler.dart#newcode46 dart/frog/leg/compiler.dart:46: final Map<Node, ClosureData> closureDataCache; This should ...

8 years, 9 months ago (2012-03-07 11:35:25 UTC) #2

karlklose

LGTM. https://chromiumcodereview.appspot.com/9567041/diff/1/dart/frog/leg/resolver.dart File dart/frog/leg/resolver.dart (right): https://chromiumcodereview.appspot.com/9567041/diff/1/dart/frog/leg/resolver.dart#newcode1441 dart/frog/leg/resolver.dart:1441: if (name === null) { This could fit ...

8 years, 9 months ago (2012-03-07 12:34:38 UTC) #3

ahe

8 years, 9 months ago (2012-03-07 21:56:08 UTC) #4

Hi Karl and Nicolas,

Thank you for your comments.

Cheers,
Peter

https://chromiumcodereview.appspot.com/9567041/diff/1/dart/frog/leg/compiler....
File dart/frog/leg/compiler.dart (right):

https://chromiumcodereview.appspot.com/9567041/diff/1/dart/frog/leg/compiler....
dart/frog/leg/compiler.dart:46: final Map<Node, ClosureData> closureDataCache;
On 2012/03/07 11:35:25, ngeoffray wrote:
> This should be a field in the builder task. But handle the move of the static
> field in another CL?

Done.

https://chromiumcodereview.appspot.com/9567041/diff/1/dart/frog/leg/resolver....
File dart/frog/leg/resolver.dart (right):

https://chromiumcodereview.appspot.com/9567041/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:1441: if (name === null) {
On 2012/03/07 12:34:39, karlklose wrote:
> This could fit in one line.

Done.

Expand Messages | Collapse Messages