Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issue 9565047: Enable optimizations for the Win32 debug build. (Closed)

Created:
8 years, 9 months ago by cshapiro
Modified:
8 years, 9 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Enable optimizations for the Win32 debug build. An equivalent change was recently done for the Macintosh and Linux targets to eliminate the substantial lag between the execution time of the release and debug builds. As the /02 (Maximize Speed) flag implies the /Oy (Frame-Pointer Omission) flag I have, in the interest of debugging, set OmitFramePointers to false. Committed: https://code.google.com/p/dart/source/detail?r=4899

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/gyp/configurations_msvs.gypi View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
cshapiro
Hi Mads, As we do not yet have a Win32 machine on-site, we would be ...
8 years, 9 months ago (2012-03-02 02:56:50 UTC) #1
Mads Ager (google)
LGTM I patched in the change, build and single-stepped through some code in the debugger. ...
8 years, 9 months ago (2012-03-02 09:18:42 UTC) #2
cshapiro
Thanks!
8 years, 9 months ago (2012-03-02 19:28:52 UTC) #3
siva
8 years, 9 months ago (2012-03-02 19:32:16 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698