Issue 9565035: Some fixes to Math.pow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9565035: Some fixes to Math.pow. (Closed)

Created:
8 years, 9 months ago by srdjan

Modified:
8 years, 9 months ago

Reviewers:
ngeoffray, hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Some fixes to Math.pow. Committed: https://code.google.com/p/dart/source/detail?r=4848

Patch Set 2 : #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	runtime/lib/double.dart	View		1 chunk	+9 lines, -1 line	2 comments	Download
	M	tests/co19/co19-runtime.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

DBC https://chromiumcodereview.appspot.com/9565035/diff/3001/runtime/lib/double.dart File runtime/lib/double.dart (right): https://chromiumcodereview.appspot.com/9565035/diff/3001/runtime/lib/double.dart#newcode116 runtime/lib/double.dart:116: return 1.0; // ECMA-262 15.8.2.13 Wouldn't it be ...

8 years, 9 months ago (2012-03-02 07:55:47 UTC) #3

srdjan

8 years, 9 months ago (2012-03-02 17:55:37 UTC) #4

https://chromiumcodereview.appspot.com/9565035/diff/3001/runtime/lib/double.dart
File runtime/lib/double.dart (right):

https://chromiumcodereview.appspot.com/9565035/diff/3001/runtime/lib/double.d...
runtime/lib/double.dart:116: return 1.0;  // ECMA-262 15.8.2.13
On 2012/03/02 07:55:47, ngeoffray wrote:
> Wouldn't it be better to point to Dart spec instead? and the Dart spec listing
> all these cases (even if the text explaining is missing).

Good point. There is no Dart library spec for "pow" yet and I will file a
request for it. The comment says that the implementation does implement what
ECMA-262 says. I think it is helpful in the way that it does not seem
arbitrarily.

Expand Messages | Collapse Messages

Issue 9565035: Some fixes to Math.pow. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages