Issue 9565016: Check type argument bounds of interfaces in type tests (work in progress).

Issue 9565016: Check type argument bounds of interfaces in type tests (work in progress). (Closed)

Created:
8 years, 9 months ago by regis

Modified:
8 years, 9 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Check type argument bounds of interfaces in type tests (work in progress). Add a new test. Fix broken tests. Committed: https://code.google.com/p/dart/source/detail?r=4819

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -33 lines)			Patch
M	runtime/vm/object.cc	View	1	2 chunks	+27 lines, -16 lines	0 comments	Download
M	tests/language/language.status	View	1	3 chunks	+3 lines, -4 lines	0 comments	Download
M	tests/language/src/Prefix22Test.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
A	tests/language/src/TypeVariableBounds2Test.dart	View		1 chunk	+50 lines, -0 lines	0 comments	Download
M	tests/language/src/TypeVariableBoundsTest.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
D	tests/language/src/WrongNumberTypeArgumentsNegativeTest.dart	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	tests/language/src/WrongNumberTypeArgumentsTest.dart	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/9565016/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://chromiumcodereview.appspot.com/9565016/diff/1/runtime/vm/object.cc#newcode1472 runtime/vm/object.cc:1472: // arguments are within the bounds specified by ...

8 years, 9 months ago (2012-03-01 19:05:02 UTC) #2

regis

8 years, 9 months ago (2012-03-01 19:54:25 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/9565016/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/9565016/diff/1/runtime/vm/object.cc#ne...
runtime/vm/object.cc:1472: // arguments are within the bounds specified by the
interface class.
On 2012/03/01 19:05:02, srdjan wrote:
> Can you please add comment how is the difference at runtime in checked mode
> on/off (not true/false, but true/error).

Done.

https://chromiumcodereview.appspot.com/9565016/diff/1/tests/language/src/Type...
File tests/language/src/TypeVariableBoundsTest.dart (right):

https://chromiumcodereview.appspot.com/9565016/diff/1/tests/language/src/Type...
tests/language/src/TypeVariableBoundsTest.dart:69: Box<Fisk> box = null; /// 09:
dynamic type error
On 2012/03/01 19:05:02, srdjan wrote:
> Check dartc, they may require  a static type error 

Apparently not. I guess a dynamic type error implies a static type error.

Expand Messages | Collapse Messages