Issue 9562048: isolate in frog: hiding internal implementation classes, couple minor fixes.

Issue 9562048: isolate in frog: hiding internal implementation classes, couple minor fixes. (Closed)

Created:
8 years, 9 months ago by Siggi Cherem (dart-lang)

Modified:
8 years, 9 months ago

Reviewers:
eub

CC:
reviews_dartlang.org, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

isolate in frog: hiding internal implementation classes, couple minor fixes. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4900

Patch Set 3 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -90 lines)			Patch
M	lib/isolate/frog/compiler_hooks.dart	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	lib/isolate/frog/isolateimpl.dart	View	1 2	22 chunks	+64 lines, -67 lines	0 comments	Download
M	lib/isolate/frog/messages.dart	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	lib/isolate/frog/ports.dart	View		5 chunks	+11 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

https://chromiumcodereview.appspot.com/9562048/diff/6/lib/isolate/frog/isolateimpl.dart File lib/isolate/frog/isolateimpl.dart (left): https://chromiumcodereview.appspot.com/9562048/diff/6/lib/isolate/frog/isolateimpl.dart#oldcode97 lib/isolate/frog/isolateimpl.dart:97: if (this.supportsWorkers) { both the comment and the condition ...

8 years, 9 months ago (2012-03-02 01:58:30 UTC) #1

eub

One question, otherwise LGTM. http://codereview.chromium.org/9562048/diff/6/lib/isolate/frog/isolateimpl.dart File lib/isolate/frog/isolateimpl.dart (right): http://codereview.chromium.org/9562048/diff/6/lib/isolate/frog/isolateimpl.dart#newcode248 lib/isolate/frog/isolateimpl.dart:248: if (_globalState.isWorker) { This was ...

8 years, 9 months ago (2012-03-02 19:48:27 UTC) #2

Siggi Cherem (dart-lang)

8 years, 9 months ago (2012-03-02 21:00:39 UTC) #3

http://codereview.chromium.org/9562048/diff/6/lib/isolate/frog/isolateimpl.dart
File lib/isolate/frog/isolateimpl.dart (right):

http://codereview.chromium.org/9562048/diff/6/lib/isolate/frog/isolateimpl.da...
lib/isolate/frog/isolateimpl.dart:248: if (_globalState.isWorker) {
On 2012/03/02 19:48:27, eub wrote:
> This was already true at the time we entered this else block.  
> Are we watching for it to change underneath our feet, or is this a redundant
> check?

totally redundant, good catch. Thanks!

Expand Messages | Collapse Messages