Issue 9562006: No IntegerDivisionByZeroException in Leg (as it only has doubles). Also fix a rounding issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9562006: No IntegerDivisionByZeroException in Leg (as it only has doubles). Also fix a rounding issue. (Closed)

Created:
8 years, 9 months ago by ahe

Modified:
8 years, 9 months ago

Reviewers:
floitsch, kasperl

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen, karlklose, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

No IntegerDivisionByZeroException in Leg (as it only has doubles). Also fix a rounding issue. Committed: https://code.google.com/p/dart/source/detail?r=4887

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -45 lines)			Patch
M	dart/frog/leg/lib/js_helper.dart	View	19 chunks	+29 lines, -27 lines	0 comments	Download
M	dart/tests/co19/co19-leg.status	View	4 chunks	+10 lines, -18 lines	0 comments	Download
M	dart/tests/language/language-leg.status	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

ahe

Leg only has one number type which should be pretty close to Dart's double. So ...

8 years, 9 months ago (2012-03-01 15:39:46 UTC) #1

LGTM.