Issue 9546015: create build_frogpad_js.py to help repro bug 1700

Issue 9546015: create build_frogpad_js.py to help repro bug 1700 (Closed)

Created:
8 years, 9 months ago by mattsh

Modified:
8 years, 9 months ago

Reviewers:
ahe, Siggi Cherem (dart-lang), ngeoffray, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

create build_frogpad_js.py to help repro bug 1700 BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5041

Patch Set 2 : removed chmod #

Total comments: 3

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -69 lines)			Patch
A	frog/scripts/bootstrap/build_frogpad_js.py	View	1	1 chunk	+50 lines, -0 lines	2 comments	Download
M	tools/testing/frogpad/frogpad.dart	View		3 chunks	+11 lines, -6 lines	0 comments	Download
M	tools/testing/frogpad/frogpad.py	View		8 chunks	+26 lines, -63 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

mattsh

with the latest dart:html, frog gets confused if the name "_get" is used in multiple ...

8 years, 9 months ago (2012-03-06 17:32:48 UTC) #1

Siggi Cherem (dart-lang)

lgtm (with fix below) https://chromiumcodereview.appspot.com/9546015/diff/1/frog/scripts/bootstrap/build_frogpad_js.py File frog/scripts/bootstrap/build_frogpad_js.py (right): https://chromiumcodereview.appspot.com/9546015/diff/1/frog/scripts/bootstrap/build_frogpad_js.py#newcode46 frog/scripts/bootstrap/build_frogpad_js.py:46: os.chmod(frogpad_js, stat.S_IXUSR | stat.S_IXGRP | ...

8 years, 9 months ago (2012-03-06 17:59:50 UTC) #2

mattsh

https://chromiumcodereview.appspot.com/9546015/diff/1/frog/scripts/bootstrap/build_frogpad_js.py File frog/scripts/bootstrap/build_frogpad_js.py (right): https://chromiumcodereview.appspot.com/9546015/diff/1/frog/scripts/bootstrap/build_frogpad_js.py#newcode46 frog/scripts/bootstrap/build_frogpad_js.py:46: os.chmod(frogpad_js, stat.S_IXUSR | stat.S_IXGRP | stat.S_IRUSR | On 2012/03/06 ...

8 years, 9 months ago (2012-03-06 18:06:46 UTC) #3

ngeoffray

https://chromiumcodereview.appspot.com/9546015/diff/5/frog/scripts/bootstrap/build_frogpad_js.py File frog/scripts/bootstrap/build_frogpad_js.py (right): https://chromiumcodereview.appspot.com/9546015/diff/5/frog/scripts/bootstrap/build_frogpad_js.py#newcode21 frog/scripts/bootstrap/build_frogpad_js.py:21: '..', '..', '..', 'out/Release_ia32')) out/Release_ia32 is linux only. I ...

8 years, 9 months ago (2012-03-07 12:53:43 UTC) #4

ahe

https://chromiumcodereview.appspot.com/9546015/diff/5/tools/testing/frogpad/frogpad.py File tools/testing/frogpad/frogpad.py (right): https://chromiumcodereview.appspot.com/9546015/diff/5/tools/testing/frogpad/frogpad.py#newcode1 tools/testing/frogpad/frogpad.py:1: #!/usr/bin/env python Why is this file in dart/tools?

8 years, 9 months ago (2012-03-07 12:56:31 UTC) #5

ahe

8 years, 9 months ago (2012-03-07 13:07:53 UTC) #6

I'm trying to extrapolate where this is heading. It looks like it may be heading
for trouble.

Please involve me in all changes to the build infrastructure, and please wait
for my comments before submitting. If this is too tedious, please let me know
what you need and I can do the GYP work for you.

https://chromiumcodereview.appspot.com/9546015/diff/5/frog/scripts/bootstrap/...
File frog/scripts/bootstrap/build_frogpad_js.py (right):

https://chromiumcodereview.appspot.com/9546015/diff/5/frog/scripts/bootstrap/...
frog/scripts/bootstrap/build_frogpad_js.py:1: # Copyright 2011 Google Inc. All
Rights Reserved.
Why is this file in scripts/bootstrap? How is this file contributing to
bootstrapping frog?

Also, why can you not use '<(PRODUCT_DIR)/frog/bin/frog'.

Expand Messages | Collapse Messages