Issue 9546003: Add method available to StringInputStream

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9546003: Add method available to StringInputStream (Closed)

Created:
8 years, 9 months ago by Søren Gjesse

Modified:
8 years, 9 months ago

Reviewers:
Mads Ager (google), Dan Rice

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add method available to StringInputStream The StringInputStream did not have any way for checking the number of available characters. Added method available like on a binary InputStream. R=ager@google.com BUG=dart:1945 TEST=tests/standalone/src/io/StringStreamTest.dart Committed: https://code.google.com/p/dart/source/detail?r=5021

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -1 line)			Patch
M	runtime/bin/input_stream.dart	View	1 chunk	+10 lines, -0 lines	1 comment	Download
M	runtime/bin/string_stream.dart	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	tests/standalone/src/io/StringStreamTest.dart	View	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dan Rice

8 years, 9 months ago (2012-03-06 15:06:56 UTC) #3

https://chromiumcodereview.appspot.com/9546003/diff/1/runtime/bin/input_strea...
File runtime/bin/input_stream.dart (right):

https://chromiumcodereview.appspot.com/9546003/diff/1/runtime/bin/input_strea...
runtime/bin/input_stream.dart:132: * less characters being returned as the line
breaking characters
less -> fewer

Expand Messages | Collapse Messages