Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 9540008: Remove non-useful duplicated code from the flow graph builder. (Closed)

Created:
8 years, 9 months ago by Kevin Millikin (Google)
Modified:
8 years, 9 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove non-useful duplicated code from the flow graph builder. For most AST nodes, there is a core of the translation that is shared for all contexts and only the handling of the final computation differs. Make this last part virtual and the visit functions non-virtual by default. We can still override visit functions if we want truly different translations. R=srdjan@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4786

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -417 lines) Patch
M runtime/vm/flow_graph_builder.h View 9 chunks +19 lines, -22 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 8 chunks +59 lines, -395 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Google)
I think it's clear that the graph builder has so much generality that it's unwieldy.
8 years, 9 months ago (2012-02-29 14:25:42 UTC) #1
srdjan
8 years, 9 months ago (2012-02-29 18:17:44 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698