Issue 9537009: Create mock versions set and sort implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9537009: Create mock versions set and sort implementations. (Closed)

Created:
8 years, 9 months ago by ahe

Modified:
8 years, 9 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, floitsch, karlklose, kasperl, Lasse Reichstein

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Create mock versions set and sort implementations. Committed: https://code.google.com/p/dart/source/detail?r=4752

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -93 lines)			Patch
M	dart/frog/leg/lib/coreimpl.dart	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	dart/frog/leg/lib/dual_pivot_quicksort.dart	View	5 chunks	+7 lines, -5 lines	0 comments	Download
M	dart/frog/leg/lib/hash_map_set.dart	View	3 chunks	+17 lines, -12 lines	1 comment	Download
M	dart/frog/leg/lib/js_helper.dart	View	2 chunks	+9 lines, -5 lines	0 comments	Download
M	dart/tests/co19/co19-leg.status	View	4 chunks	+2 lines, -66 lines	0 comments	Download
M	dart/tests/corelib/corelib-leg.status	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	dart/tests/language/language-leg.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ahe

https://chromiumcodereview.appspot.com/9537009/diff/1/dart/frog/leg/lib/hash_map_set.dart File dart/frog/leg/lib/hash_map_set.dart (right): https://chromiumcodereview.appspot.com/9537009/diff/1/dart/frog/leg/lib/hash_map_set.dart#newcode311 dart/frog/leg/lib/hash_map_set.dart:311: var self = this; I should be able to ...

8 years, 9 months ago (2012-02-29 12:37:20 UTC) #1

LGTM

Expand Messages | Collapse Messages