Issue 9535012: Introduce the legium component in test.dart, and start support for dart:dom and dart:html.

Issue 9535012: Introduce the legium component in test.dart, and start support for dart:dom and dart:html. (Closed)

Created:
8 years, 9 months ago by ngeoffray

Modified:
8 years, 9 months ago

Reviewers:
ahe, kasperl

CC:
reviews_dartlang.org, floitsch, karlklose, Lasse Reichstein Nielsen, sra1

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Introduce the legium component in test.dart, and start support for dart:dom and dart:html. Committed: https://code.google.com/p/dart/source/detail?r=4787

Patch Set 4 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -7 lines)			Patch
M	frog/leg/compiler.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	frog/leg/frog_leg.dart	View	1 2 3	1 chunk	+14 lines, -0 lines	0 comments	Download
M	frog/leg/native_handler.dart	View	1 2 3	2 chunks	+8 lines, -2 lines	0 comments	Download
M	frog/leg/scanner/scanner_task.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/testing/dart/test_options.dart	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1 2 3	6 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

But don't get your hopes too high :) We can't run any tests yet, I ...

8 years, 9 months ago (2012-02-29 16:40:27 UTC) #1

ahe

LGTM https://chromiumcodereview.appspot.com/9535012/diff/2001/frog/leg/frog_leg.dart File frog/leg/frog_leg.dart (right): https://chromiumcodereview.appspot.com/9535012/diff/2001/frog/leg/frog_leg.dart#newcode94 frog/leg/frog_leg.dart:94: if (uriName == 'dart:dom') { Please add: // ...

8 years, 9 months ago (2012-02-29 17:35:27 UTC) #2

kasperl

LGTM. Sorry to say so, but my hopes *are* high :-) https://chromiumcodereview.appspot.com/9535012/diff/2001/frog/leg/frog_leg.dart File frog/leg/frog_leg.dart (right): ...

8 years, 9 months ago (2012-03-01 06:30:15 UTC) #3

ngeoffray

8 years, 9 months ago (2012-03-01 08:57:57 UTC) #4

Thanks Peter and Kasper.

https://chromiumcodereview.appspot.com/9535012/diff/2001/frog/leg/frog_leg.dart
File frog/leg/frog_leg.dart (right):

https://chromiumcodereview.appspot.com/9535012/diff/2001/frog/leg/frog_leg.da...
frog/leg/frog_leg.dart:87: Uri getUriOf(String fileName) {
On 2012/03/01 06:30:15, kasperl wrote:
> I would call this getUriFor because the file name doesn't have a URI.

Done.

https://chromiumcodereview.appspot.com/9535012/diff/2001/frog/leg/frog_leg.da...
frog/leg/frog_leg.dart:94: if (uriName == 'dart:dom') {
On 2012/02/29 17:35:27, ahe wrote:
> Please add:
> 
> // TODO(ahe): Clean this up.

Done.

https://chromiumcodereview.appspot.com/9535012/diff/2001/frog/leg/scanner/sca...
File frog/leg/scanner/scanner_task.dart (right):

https://chromiumcodereview.appspot.com/9535012/diff/2001/frog/leg/scanner/sca...
frog/leg/scanner/scanner_task.dart:96: native.checkNativeSupport(compiler,
element, libraryName);
On 2012/02/29 17:35:27, ahe wrote:
> I think you should pass the URI in here instead.

Done.

Expand Messages | Collapse Messages