Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 9526001: Fix issue 1845: Mint BIT_AND Smi was incorrect for negative Smi-s. Jump to slow case on negative Sm… (Closed)

Created:
8 years, 9 months ago by srdjan
Modified:
8 years, 9 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix issue 1845: Mint BIT_AND Smi was incorrect for negative Smi-s. Jump to slow case on negative Smi since the result will be Mint anyway. Committed: https://code.google.com/p/dart/source/detail?r=4730

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M runtime/vm/opt_code_generator_ia32.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M tests/standalone/src/MediumIntegerTest.dart View 1 3 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
srdjan
8 years, 9 months ago (2012-02-29 01:02:55 UTC) #1
siva
8 years, 9 months ago (2012-02-29 01:07:15 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698