Issue 9523001: Teach the flow graph compiler to play nice with the debugger

Issue 9523001: Teach the flow graph compiler to play nice with the debugger (Closed)

Created:
8 years, 9 months ago by hausner

Modified:
8 years, 9 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, Kevin Millikin (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Teach the flow graph compiler to play nice with the debugger Add PC descriptors for return statements. Fixing blood red build bot. Committed: https://code.google.com/p/dart/source/detail?r=4725

Patch Set 1 #

Total comments: 5

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -2 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 chunk	+14 lines, -0 lines	3 comments	Download
M	runtime/vm/intermediate_language.h	View	2 chunks	+4 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM http://codereview.chromium.org/9523001/diff/1/runtime/vm/flow_graph_compiler_x64.cc File runtime/vm/flow_graph_compiler_x64.cc (right): http://codereview.chromium.org/9523001/diff/1/runtime/vm/flow_graph_compiler_x64.cc#newcode153 runtime/vm/flow_graph_compiler_x64.cc:153: // return pattern with a call to the ...

8 years, 9 months ago (2012-02-28 21:37:40 UTC) #2

hausner

Thank you. http://codereview.chromium.org/9523001/diff/1/runtime/vm/flow_graph_compiler_x64.cc File runtime/vm/flow_graph_compiler_x64.cc (right): http://codereview.chromium.org/9523001/diff/1/runtime/vm/flow_graph_compiler_x64.cc#newcode153 runtime/vm/flow_graph_compiler_x64.cc:153: // return pattern with a call to ...

8 years, 9 months ago (2012-02-28 21:42:34 UTC) #3

srdjan

8 years, 9 months ago (2012-02-28 21:51:48 UTC) #4

http://codereview.chromium.org/9523001/diff/1/runtime/vm/flow_graph_compiler_...
File runtime/vm/flow_graph_compiler_x64.cc (right):

http://codereview.chromium.org/9523001/diff/1/runtime/vm/flow_graph_compiler_...
runtime/vm/flow_graph_compiler_x64.cc:153: // return pattern with a call to the
debug stub.
On 2012/02/28 21:42:34, hausner wrote:
> On 2012/02/28 21:37:40, srdjan wrote:
> > __ nop(8) instead ?
> 
> With 8 0x90 bytes it's easier to find the code pattern in the debugger to
patch
> it. this code is never executed, so speed is no issue.

You may want to add a comment that the pattern of 8 1-nops is important,
otherwise it is very tempting to replace it with nop(8).

Expand Messages | Collapse Messages