Add support for malformed types and postpone some related errors from compile

Add support for malformed types and postpone some related errors from compile
time to execution time.

Still to do (once spec is clarified):
- properly handle generic type bounds errors
- properly handle 'instance of' type checks involving malformed types
- fix bad tests
Committed: https://code.google.com/p/dart/source/detail?r=4732

[hausner, 2012-02-28 23:52:58]

lgtm

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/class_finali...
File runtime/vm/class_finalizer.h (right):

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/class_finali...
runtime/vm/class_finalizer.h:50: kFinalizeWellFormed  // Error-free resolution
and finalization are required.
There is at least one place in the parser where you depend on the order of the
enum values. Maybe you should add a comment. Also, it would be neat if the
comments lined up on the right.

[regis, 2012-02-29 00:05:23]

Thanks!

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/class_finali...
File runtime/vm/class_finalizer.h (right):

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/class_finali...
runtime/vm/class_finalizer.h:50: kFinalizeWellFormed  // Error-free resolution
and finalization are required.
On 2012/02/28 23:52:59, hausner wrote:
> There is at least one place in the parser where you depend on the order of the
> enum values. Maybe you should add a comment. Also, it would be neat if the
> comments lined up on the right.

Done.

[srdjan, 2012-02-29 00:15:54]

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/lib/error.dart
File runtime/lib/error.dart (right):

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/lib/error.dart#...
runtime/lib/error.dart:39: return "'$url': Failed type check: line $line pos
$column: " +
no else is needed

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/class_finali...
File runtime/vm/class_finalizer.h (right):

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/class_finali...
runtime/vm/class_finalizer.h:44: enum TypeFinalization {
Maybe FinalizationKind is a better name?

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/code_generat...
File runtime/vm/code_generator_ia32.cc (right):

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/code_generat...
runtime/vm/code_generator_ia32.cc:1483: __ PushObject(result);  // Make room for
the result of the runtime call.
__ PushObject(Object::ZoneHandle());

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/code_generat...
runtime/vm/code_generator_ia32.cc:1483: __ PushObject(result);  // Make room for
the result of the runtime call.
Is this precaution to push a dummy for result? MalformedTypeError is not setting
a result, is it?

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/code_generat...
File runtime/vm/code_generator_x64.cc (right):

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/code_generat...
runtime/vm/code_generator_x64.cc:1472: __ PushObject(result);  // Make room for
the result of the runtime call.
ditto

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:5486: if (type.IsMalformed()) {
Could you factor this code out please.

https://chromiumcodereview.appspot.com/9515011/diff/1/tests/co19/co19-runtime...
File tests/co19/co19-runtime.status (right):

https://chromiumcodereview.appspot.com/9515011/diff/1/tests/co19/co19-runtime...
tests/co19/co19-runtime.status:178: Language/09_Generics/09_Generics_A04_t05:
Fail  # Should not expect a compile time error.
Please file an issue with co19 and put the issue number here.

[srdjan, 2012-02-29 00:16:50]

And LGTM

[regis, 2012-02-29 02:10:01]

Thanks!

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/lib/error.dart
File runtime/lib/error.dart (right):

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/lib/error.dart#...
runtime/lib/error.dart:39: return "'$url': Failed type check: line $line pos
$column: " +
On 2012/02/29 00:15:54, srdjan wrote:
> no else is needed

Done.

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/class_finali...
File runtime/vm/class_finalizer.h (right):

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/class_finali...
runtime/vm/class_finalizer.h:44: enum TypeFinalization {
On 2012/02/29 00:15:54, srdjan wrote:
> Maybe FinalizationKind is a better name?

Renamed to FinalizationMode.

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/code_generat...
File runtime/vm/code_generator_ia32.cc (right):

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/code_generat...
runtime/vm/code_generator_ia32.cc:1483: __ PushObject(result);  // Make room for
the result of the runtime call.
On 2012/02/29 00:15:54, srdjan wrote:
> Is this precaution to push a dummy for result? MalformedTypeError is not
setting
> a result, is it?

Correct. No result is returned, but we always reserve space for the result
anyway out of precaution.

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/code_generat...
runtime/vm/code_generator_ia32.cc:1483: __ PushObject(result);  // Make room for
the result of the runtime call.
On 2012/02/29 00:15:54, srdjan wrote:
> __ PushObject(Object::ZoneHandle());

Done here and in other places.

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/code_generat...
File runtime/vm/code_generator_x64.cc (right):

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/code_generat...
runtime/vm/code_generator_x64.cc:1472: __ PushObject(result);  // Make room for
the result of the runtime call.
On 2012/02/29 00:15:54, srdjan wrote:
> ditto

Done.

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/9515011/diff/1/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:5486: if (type.IsMalformed()) {
On 2012/02/29 00:15:54, srdjan wrote:
> Could you factor this code out please.

Done.

https://chromiumcodereview.appspot.com/9515011/diff/1/tests/co19/co19-runtime...
File tests/co19/co19-runtime.status (right):

https://chromiumcodereview.appspot.com/9515011/diff/1/tests/co19/co19-runtime...
tests/co19/co19-runtime.status:178: Language/09_Generics/09_Generics_A04_t05:
Fail  # Should not expect a compile time error.
On 2012/02/29 00:15:54, srdjan wrote:
> Please file an issue with co19 and put the issue number here.

Issue co19 83 filed.
Earlier, in patch 2, I filed issue co19 82.