Issue 9502002: Add FunctionDeclaration node.

Issue 9502002: Add FunctionDeclaration node. (Closed)

Created:
8 years, 9 months ago by floitsch

Modified:
8 years, 9 months ago

Reviewers:
karlklose, ahe, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add FunctionDeclaration node. Committed: https://code.google.com/p/dart/source/detail?r=4707

Patch Set 2 : Update status files. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -46 lines)			Patch
M	frog/leg/resolver.dart	View		2 chunks	+11 lines, -1 line	0 comments	Download
M	frog/leg/scanner/listener.dart	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	frog/leg/scanner/parser.dart	View		3 chunks	+9 lines, -2 lines	0 comments	Download
M	frog/leg/ssa/builder.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	frog/leg/ssa/closure.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	frog/leg/tree/nodes.dart	View		3 chunks	+17 lines, -0 lines	0 comments	Download
M	frog/leg/tree/unparser.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	frog/leg/tree/visitors.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	frog/leg/typechecker.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	tests/co19/co19-leg.status	View	1	5 chunks	+3 lines, -28 lines	0 comments	Download
M	tests/language/language-leg.status	View	1	7 chunks	+14 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

I still need to update the status files and fix one crash that appears now. ...

8 years, 9 months ago (2012-02-28 16:53:37 UTC) #1

ngeoffray

LGTM! https://chromiumcodereview.appspot.com/9502002/diff/1/frog/leg/typechecker.dart File frog/leg/typechecker.dart (right): https://chromiumcodereview.appspot.com/9502002/diff/1/frog/leg/typechecker.dart#newcode276 frog/leg/typechecker.dart:276: analyze(node.function); Add a TODO that this is not ...

8 years, 9 months ago (2012-02-28 17:11:50 UTC) #3

floitsch

updated status file. Investigating the crash in a separate CL. https://chromiumcodereview.appspot.com/9502002/diff/1/frog/leg/typechecker.dart File frog/leg/typechecker.dart (right): https://chromiumcodereview.appspot.com/9502002/diff/1/frog/leg/typechecker.dart#newcode276 ...

8 years, 9 months ago (2012-02-28 17:35:20 UTC) #4

LGTM.

Expand Messages | Collapse Messages