Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 9494012: Add supplementals for several unforked WebKit idls. (Closed)

Created:
8 years, 9 months ago by podivilov
Modified:
8 years, 9 months ago
Reviewers:
sra, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add supplementals for several unforked WebKit idls. R=sra@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=4739

Patch Set 1 #

Patch Set 2 : . #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M client/dom/idl/dart/dart.idl View 1 3 chunks +27 lines, -9 lines 3 comments Download

Messages

Total messages: 4 (0 generated)
podivilov
8 years, 9 months ago (2012-02-28 15:19:46 UTC) #1
sra1
lgtm https://chromiumcodereview.appspot.com/9494012/diff/2001/client/dom/idl/dart/dart.idl File client/dom/idl/dart/dart.idl (right): https://chromiumcodereview.appspot.com/9494012/diff/2001/client/dom/idl/dart/dart.idl#newcode81 client/dom/idl/dart/dart.idl:81: readonly attribute CanvasPixelArray data; I remember this being ...
8 years, 9 months ago (2012-02-28 18:48:42 UTC) #2
podivilov
https://chromiumcodereview.appspot.com/9494012/diff/2001/client/dom/idl/dart/dart.idl File client/dom/idl/dart/dart.idl (right): https://chromiumcodereview.appspot.com/9494012/diff/2001/client/dom/idl/dart/dart.idl#newcode81 client/dom/idl/dart/dart.idl:81: readonly attribute CanvasPixelArray data; On 2012/02/28 18:48:42, sra1 wrote: ...
8 years, 9 months ago (2012-02-29 08:17:39 UTC) #3
podivilov
8 years, 9 months ago (2012-02-29 08:25:33 UTC) #4
https://chromiumcodereview.appspot.com/9494012/diff/2001/client/dom/idl/dart/...
File client/dom/idl/dart/dart.idl (right):

https://chromiumcodereview.appspot.com/9494012/diff/2001/client/dom/idl/dart/...
client/dom/idl/dart/dart.idl:81: readonly attribute CanvasPixelArray data;
On 2012/02/29 08:17:39, podivilov wrote:
> On 2012/02/28 18:48:42, sra1 wrote:
> > I remember this being there - our tests use it.
> > Did this get removed as a result of unforking?
> 
> I think it was "interface CanvasPixelArray" actually.

CanvasPixelArray lives behind "defined(V8_BINDING)". We added "||
defined(LANGUAGE_DART)" long ago, and now I'm reverting it since Dartium now
uses dart.idl supplementals.

Powered by Google App Engine
This is Rietveld 408576698