Issue 9487004: Initialize fields with their default values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9487004: Initialize fields with their default values. (Closed)

Created:
8 years, 9 months ago by floitsch

Modified:
8 years, 9 months ago

Reviewers:
karlklose, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Initialize fields with their default values. Committed: https://code.google.com/p/dart/source/detail?r=4670

Patch Set 2 : Missed one test. #

Total comments: 2

Patch Set 3 : Two other tests work after rebase. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -13 lines)			Patch
M	frog/leg/ssa/builder.dart	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	tests/co19/co19-leg.status	View	1 2	2 chunks	+0 lines, -7 lines	0 comments	Download
M	tests/language/language-leg.status	View	1 2	4 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

DBC https://chromiumcodereview.appspot.com/9487004/diff/3001/frog/leg/ssa/builder.dart File frog/leg/ssa/builder.dart (right): https://chromiumcodereview.appspot.com/9487004/diff/3001/frog/leg/ssa/builder.dart#newcode815 frog/leg/ssa/builder.dart:815: // other constants and should be at the ...

8 years, 9 months ago (2012-02-28 09:48:26 UTC) #2

floitsch

8 years, 9 months ago (2012-02-28 10:19:01 UTC) #4

https://chromiumcodereview.appspot.com/9487004/diff/3001/frog/leg/ssa/builder...
File frog/leg/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/9487004/diff/3001/frog/leg/ssa/builder...
frog/leg/ssa/builder.dart:815: // other constants and should be at the top of
the graph.
On 2012/02/28 09:48:26, ngeoffray wrote:
> Why can't you do it?

We could, but it would be tedious and I'm about to refactor this part.