Issue 9481019: Changes to get rid of dependency on openssl in the dart VM.

Issue 9481019: Changes to get rid of dependency on openssl in the dart VM. (Closed)

Created:
8 years, 9 months ago by siva

Modified:
8 years, 9 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Changes to get rid of dependency on openssl in the dart VM. (This will enable dartium to be built on the windows platform). Committed: https://code.google.com/p/dart/source/detail?r=4717

Patch Set 3 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1352 lines, -603 lines)			Patch
M	bin/bin.gypi	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/integers.cc	View	3 chunks	+3 lines, -19 lines	0 comments	Download
M	platform/globals.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	vm/bigint_operations.h	View	4 chunks	+65 lines, -34 lines	0 comments	Download
M	vm/bigint_operations.cc	View	10 chunks	+1146 lines, -359 lines	0 comments	Download
M	vm/bigint_operations_test.cc	View	9 chunks	+21 lines, -51 lines	0 comments	Download
D	vm/bigint_store.h	View	1 chunk	+0 lines, -37 lines	0 comments	Download
M	vm/dart_api_impl.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	vm/isolate.h	View	3 chunks	+0 lines, -5 lines	0 comments	Download
M	vm/isolate.cc	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	vm/object.h	View	2 chunks	+42 lines, -29 lines	0 comments	Download
M	vm/object.cc	View	6 chunks	+34 lines, -31 lines	0 comments	Download
M	vm/object_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	vm/raw_object.h	View	1 chunk	+12 lines, -5 lines	0 comments	Download
M	vm/raw_object.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	vm/raw_object_snapshot.cc	View	1 chunk	+12 lines, -2 lines	0 comments	Download
M	vm/snapshot_test.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	vm/vm.gypi	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	vm/vm_sources.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -Ivan https://chromiumcodereview.appspot.com/9481019/diff/21/vm/bigint_operations.cc File vm/bigint_operations.cc (right): https://chromiumcodereview.appspot.com/9481019/diff/21/vm/bigint_operations.cc#newcode345 vm/bigint_operations.cc:345: (static_cast<size_t>(kDigitBitSize) < sizeof(intptr_t) * 8)) { 8 ...

8 years, 9 months ago (2012-02-28 01:38:33 UTC) #2

siva

8 years, 9 months ago (2012-02-28 18:22:18 UTC) #3

https://chromiumcodereview.appspot.com/9481019/diff/21/vm/bigint_operations.cc
File vm/bigint_operations.cc (right):

https://chromiumcodereview.appspot.com/9481019/diff/21/vm/bigint_operations.c...
vm/bigint_operations.cc:345: (static_cast<size_t>(kDigitBitSize) <
sizeof(intptr_t) * 8)) {
On 2012/02/28 01:38:34, Ivan Posva wrote:
> 8 -> kBitsPerByte

Done.

https://chromiumcodereview.appspot.com/9481019/diff/21/vm/bigint_operations.c...
vm/bigint_operations.cc:385: RawSmi* BigintOperations::ToSmi(const Bigint&
bigint) {
They are FitsIntoInt64 and ToInt64 respectively.

Renamed these methods to FitsIntoMint and ToMint

On 2012/02/28 01:38:34, Ivan Posva wrote:
> Will we need a FitsIntoMint and ToMint as well?

https://chromiumcodereview.appspot.com/9481019/diff/21/vm/bigint_operations.h
File vm/bigint_operations.h (right):

https://chromiumcodereview.appspot.com/9481019/diff/21/vm/bigint_operations.h...
vm/bigint_operations.h:24: 
Removed.

On 2012/02/28 01:38:34, Ivan Posva wrote:
> Extra line?

https://chromiumcodereview.appspot.com/9481019/diff/21/vm/object.cc
File vm/object.cc (right):

https://chromiumcodereview.appspot.com/9481019/diff/21/vm/object.cc#newcode6348
vm/object.cc:6348: return BigintOperations::ToHexCString(*this, &ZoneAllocator);
On 2012/02/28 01:38:34, Ivan Posva wrote:
> Can you please add a TODO and file a bug to implement proper printing to a
> decimal string? Thanks!

Done.

Expand Messages | Collapse Messages