Adding webdriver setup script.

Adding webdriver setup script.
Committed: https://code.google.com/p/dart/source/detail?r=4849

[Emily Fortuna, 2012-02-28 07:06:51]

Hi John,
I'd appreciate it if you get a chance to look over my CL -- I still need to make
some tweaks to the last file (test_runner.dart) before it can be checked in, but
I wanted to get your input on the rest of the CL when you get a chance (I'm
sending this now since I wasn't sure what hours of the day you'd be working with
the jet lag and all).

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/dart/test...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/dart/test...
tools/testing/dart/test_runner.dart:701: selenium_server = new
Process.start('java', ['-jar', ]);//TODO(efortuna)
This section isn't done (I need to find the correct selenium jar to run). Feel
free to ignore this file for now.

[Jennifer Messerly, 2012-02-28 16:56:55]

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/browser_R...
File tools/testing/browser_README.txt (right):

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/browser_R...
tools/testing/browser_README.txt:62: d) (Mac only) Download the selenium server
and place it in this directory:
maybe we should do this on Windows too -- for Safari/Opera on Win?

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/browser_R...
tools/testing/browser_README.txt:71: 11)Install matplotlib
http://matplotlib.sourceforge.net/
is this:
easy_install-2.6 numpy
easy_install-2.6 matplotlib?

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/dart/test...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/dart/test...
tools/testing/dart/test_runner.dart:701: selenium_server = new
Process.start('java', ['-jar', ]);//TODO(efortuna)
On 2012/02/28 07:06:51, Emily Fortuna wrote:
> This section isn't done (I need to find the correct selenium jar to run). Feel
> free to ignore this file for now.

maybe require it to be downloaded to a particular path relative to test.dart?

(Another idea: I wonder if we can get some things pre-installed on the build
bots on their special drive.)

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/perf_test...
File tools/testing/perf_testing/buildbot_browser_test_setup.sh (right):

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/perf_test...
tools/testing/perf_testing/buildbot_browser_test_setup.sh:15: curl
http://selenium.googlecode.com/files/selenium-server-standalone-2.15.0.jar >
selenium-server-standalone-2.15.0.jar
perhaps curl -o? e.g.
curl -o selenium-server-standalone-2.15.0.jar
http://selenium.googlecode.com/files/selenium-server-standalone-2.15.0.jar

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/perf_test...
tools/testing/perf_testing/buildbot_browser_test_setup.sh:16: wget -O -
http://releases.mozilla.org/pub/mozilla.org/firefox/releases/latest/linux-x86...
| tar -C ~ -jxv
this could probably be curl too, for consistency.

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/webdriver...
File tools/testing/webdriver_test_setup.py (right):

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/webdriver...
tools/testing/webdriver_test_setup.py:70: class GoogleCodeInstaller:
style nit, I'd change this to new-style class:
    class GoogleCodeInstaller(object):

(due to some unfortunate Python legacy, it actually has different semantics:
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Classes)

& same thing for the other classes

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/webdriver...
tools/testing/webdriver_test_setup.py:98: downloads(!).
perhaps worth reporting?
http://groups.google.com/group/google-code-hosting

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/webdriver...
tools/testing/webdriver_test_setup.py:138: def get_os_str(self):
perhaps:

  @property
  def os_str(self):

[Emily Fortuna, 2012-02-29 01:10:33]

PTAL. I'm adding Siggi to look over this after our discussion about
asynchronously starting the Selenium server.

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/browser_R...
File tools/testing/browser_README.txt (right):

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/browser_R...
tools/testing/browser_README.txt:62: d) (Mac only) Download the selenium server
and place it in this directory:
On 2012/02/28 16:56:56, John Messerly wrote:
> maybe we should do this on Windows too -- for Safari/Opera on Win?

Good call. I'll update that.

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/browser_R...
tools/testing/browser_README.txt:71: 11)Install matplotlib
http://matplotlib.sourceforge.net/
On 2012/02/28 16:56:56, John Messerly wrote:
> is this:
> easy_install-2.6 numpy
> easy_install-2.6 matplotlib?

Potentially, yes, though I recall having substantial difficulties getting
matplotlib properly on each platform in a single uniform way. I'll add this
though and test it. What's the difference between easy_install-2.6 and plain
easy_install?

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/dart/test...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/dart/test...
tools/testing/dart/test_runner.dart:701: selenium_server = new
Process.start('java', ['-jar', ]);//TODO(efortuna)
On 2012/02/28 16:56:56, John Messerly wrote:
> On 2012/02/28 07:06:51, Emily Fortuna wrote:
> > This section isn't done (I need to find the correct selenium jar to run).
Feel
> > free to ignore this file for now.
> 
> maybe require it to be downloaded to a particular path relative to test.dart?
> 
> (Another idea: I wonder if we can get some things pre-installed on the build
> bots on their special drive.)

Yes, I will have it downloaded in a particular location, the issue here is I
need to determine what version the user is running
selenium-server-standalone-2.15 or 2.20, etc because my setup script downloads
whatever is latest from the repo.

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/webdriver...
File tools/testing/webdriver_test_setup.py (right):

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/webdriver...
tools/testing/webdriver_test_setup.py:70: class GoogleCodeInstaller:
On 2012/02/28 16:56:56, John Messerly wrote:
> style nit, I'd change this to new-style class:
>     class GoogleCodeInstaller(object):
> 
> (due to some unfortunate Python legacy, it actually has different semantics:
> http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Classes)
> 
> & same thing for the other classes

Done.

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/webdriver...
tools/testing/webdriver_test_setup.py:98: downloads(!).
On 2012/02/28 16:56:56, John Messerly wrote:
> perhaps worth reporting?
> http://groups.google.com/group/google-code-hosting

Done. I've cc'd you on the message... it has to get approved by moderators
first.

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/webdriver...
tools/testing/webdriver_test_setup.py:138: def get_os_str(self):
On 2012/02/28 16:56:56, John Messerly wrote:
> perhaps:
> 
>   @property
>   def os_str(self):

Done.

[Siggi Cherem (dart-lang), 2012-02-29 02:12:08]

I only looked at the test_runner.dart code, btw.

https://chromiumcodereview.appspot.com/9480019/diff/16001/tools/testing/dart/...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/9480019/diff/16001/tools/testing/dart/...
tools/testing/dart/test_runner.dart:605: startingServer = false;
you should be able to initialize both inline in the declaration above.

https://chromiumcodereview.appspot.com/9480019/diff/16001/tools/testing/dart/...
tools/testing/dart/test_runner.dart:727: && seleniumServer == null &&
startingServer == false) {
style nit: I'd move these last two conditions into the method and call it
'_ensureSeleniumServer'. For instance:
if (platform... && safari) _ensureSeleniumServer();

void _ensureSeleniumServer() {
 if (seleniumServer != null || startingServer) return;
 startingServer = true;
 ...
}

https://chromiumcodereview.appspot.com/9480019/diff/16001/tools/testing/dart/...
tools/testing/dart/test_runner.dart:763: // TODO(efortuna): Clean this up when
the IO API provides more.
instead of reading the output of dir/ls to find the name of the jar, can we use
[Directory] for this?

For instance:
Directory dir = new Directory(filePath);
dir.fileHandler = (String filename) {
  if (const RegExp(@"selenium-server-.*\.jar").hasMatch(filename)) {
    var seleniumProcess = new Process.start(....);
    ...   
  }
}

https://chromiumcodereview.appspot.com/9480019/diff/16001/tools/testing/dart/...
tools/testing/dart/test_runner.dart:767: var seleniumProcess = new
Process.start('java', ['-jar',
does this process print anything when it's ready?

If so, instead of doing
new Timer(..., 8000);

which feels it could be flaky, we could attach a handler for the output of this
process.

You could either use seleniumProcess.stdout.dataHandler, or if there is a
special line in the output that says when the server is ready, you could use a
line-reader like you did for the directory listing. Then you'd call _tryRunTest
when you match the line that indicates that the server is ready.

https://chromiumcodereview.appspot.com/9480019/diff/16001/tools/testing/dart/...
tools/testing/dart/test_runner.dart:782: seleniumJar =
stderrStringStream.readLine();
should this be stdoutStringStream? (of course this would go away if we can
replace it with Directory)

https://chromiumcodereview.appspot.com/9480019/diff/16001/tools/testing/dart/...
tools/testing/dart/test_runner.dart:818: && seleniumServer == null) {
should this also check for safari & mac? maybe introduce a small function
[_isSeleniumIsAvailable]

[Jennifer Messerly, 2012-02-29 08:51:19]

lgtm if Siggi's comments in test_runner are addressed.

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/browser_R...
File tools/testing/browser_README.txt (right):

https://chromiumcodereview.appspot.com/9480019/diff/1/tools/testing/browser_R...
tools/testing/browser_README.txt:71: 11)Install matplotlib
http://matplotlib.sourceforge.net/
On 2012/02/29 01:10:34, Emily Fortuna wrote:
> On 2012/02/28 16:56:56, John Messerly wrote:
> > is this:
> > easy_install-2.6 numpy
> > easy_install-2.6 matplotlib?
> 
> Potentially, yes, though I recall having substantial difficulties getting
> matplotlib properly on each platform in a single uniform way. I'll add this
> though and test it. What's the difference between easy_install-2.6 and plain
> easy_install?
> 

Just that it makes you to pick which version of Python you want. 
But you're right--I had difficulty getting matplotlib installed too on Mac.
Probably best to leave it pointing at the instructions :)

https://chromiumcodereview.appspot.com/9480019/diff/16001/tools/testing/dart/...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/9480019/diff/16001/tools/testing/dart/...
tools/testing/dart/test_runner.dart:727: && seleniumServer == null &&
startingServer == false) {
On 2012/02/29 02:12:08, sigmund wrote:
> style nit: I'd move these last two conditions into the method and call it
> '_ensureSeleniumServer'. For instance:
> if (platform... && safari) _ensureSeleniumServer();
> 
> void _ensureSeleniumServer() {
>  if (seleniumServer != null || startingServer) return;
>  startingServer = true;
>  ...
> }

+1

https://chromiumcodereview.appspot.com/9480019/diff/16001/tools/testing/dart/...
tools/testing/dart/test_runner.dart:818: && seleniumServer == null) {
On 2012/02/29 02:12:08, sigmund wrote:
> should this also check for safari & mac? maybe introduce a small function
> [_isSeleniumIsAvailable]

also: we have a decent number of "test.configuration['component'] ==
'webdriver'" checks. Perhaps test.useWebDriver? I've thought about adding
something that in a change I'm working on. What do y'all think?

[Emily Fortuna, 2012-03-01 23:55:12]

ptal!

https://chromiumcodereview.appspot.com/9480019/diff/16001/tools/testing/dart/...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/9480019/diff/16001/tools/testing/dart/...
tools/testing/dart/test_runner.dart:605: startingServer = false;
On 2012/02/29 02:12:08, sigmund wrote:
> you should be able to initialize both inline in the declaration above.

Done.

https://chromiumcodereview.appspot.com/9480019/diff/16001/tools/testing/dart/...
tools/testing/dart/test_runner.dart:727: && seleniumServer == null &&
startingServer == false) {
On 2012/02/29 08:51:21, John Messerly wrote:
> On 2012/02/29 02:12:08, sigmund wrote:
> > style nit: I'd move these last two conditions into the method and call it
> > '_ensureSeleniumServer'. For instance:
> > if (platform... && safari) _ensureSeleniumServer();
> > 
> > void _ensureSeleniumServer() {
> >  if (seleniumServer != null || startingServer) return;
> >  startingServer = true;
> >  ...
> > }
> 
> +1

Done.

https://chromiumcodereview.appspot.com/9480019/diff/16001/tools/testing/dart/...
tools/testing/dart/test_runner.dart:818: && seleniumServer == null) {
On 2012/02/29 02:12:08, sigmund wrote:
> should this also check for safari & mac? maybe introduce a small function
> [_isSeleniumIsAvailable]

Done.

https://chromiumcodereview.appspot.com/9480019/diff/16001/tools/testing/dart/...
tools/testing/dart/test_runner.dart:818: && seleniumServer == null) {
On 2012/02/29 08:51:21, John Messerly wrote:
> On 2012/02/29 02:12:08, sigmund wrote:
> > should this also check for safari & mac? maybe introduce a small function
> > [_isSeleniumIsAvailable]
> 
> also: we have a decent number of "test.configuration['component'] ==
> 'webdriver'" checks. Perhaps test.useWebDriver? I've thought about adding
> something that in a change I'm working on. What do y'all think?

Done.

[Siggi Cherem (dart-lang), 2012-03-02 01:16:40]

changes in test_runner lgtm

https://chromiumcodereview.appspot.com/9480019/diff/34004/tools/testing/dart/...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/9480019/diff/34004/tools/testing/dart/...
tools/testing/dart/test_runner.dart:809: String command = 'ls';
remove this and the next line (dead variables)