Support named ctors.

Support named ctors.

Committed: https://code.google.com/p/dart/source/detail?r=4632

[podivilov, 2012-02-27 15:53:48]

http://codereview.chromium.org/9480001/diff/1/client/dom/scripts/systemnative.py
File client/dom/scripts/systemnative.py (right):

http://codereview.chromium.org/9480001/diff/1/client/dom/scripts/systemnative...
client/dom/scripts/systemnative.py:291: '        Document* document =
domWindow->document();\n')
Our constructors seems to be very simple comparing to CodeGeneratorV8 ones.
Could you please compare implementations and add fixmes? E.g. add document to
DOM map to ensure that newly created node won't be collected prematurely (even
if we don't support grouping yet).

http://codereview.chromium.org/9480001/diff/1/client/dom/scripts/systemnative...
client/dom/scripts/systemnative.py:750: if
idl_argument.ext_attrs.get('Optional') == 'DefaultIsNullString':
This code is not actually used, do we really want to keep it?

[antonm, 2012-02-27 15:59:36]

http://codereview.chromium.org/9480001/diff/1/client/dom/scripts/systemnative.py
File client/dom/scripts/systemnative.py (right):

http://codereview.chromium.org/9480001/diff/1/client/dom/scripts/systemnative...
client/dom/scripts/systemnative.py:291: '        Document* document =
domWindow->document();\n')
I am not sure.  For example, I am not sure they really need to wrap document in
v8---object grouping should work in any case.

On 2012/02/27 15:53:48, podivilov wrote:
> Our constructors seems to be very simple comparing to CodeGeneratorV8 ones.
> Could you please compare implementations and add fixmes? E.g. add document to
> DOM map to ensure that newly created node won't be collected prematurely (even
> if we don't support grouping yet).

http://codereview.chromium.org/9480001/diff/1/client/dom/scripts/systemnative...
client/dom/scripts/systemnative.py:750: if
idl_argument.ext_attrs.get('Optional') == 'DefaultIsNullString':
On 2012/02/27 15:53:48, podivilov wrote:
> This code is not actually used, do we really want to keep it?

Why it's not used?  It's need, e.g., to make (most probably slightly incorrect)
test to pass

[podivilov, 2012-02-27 16:59:49]

lgtm

http://codereview.chromium.org/9480001/diff/1/client/dom/scripts/systemnative.py
File client/dom/scripts/systemnative.py (right):

http://codereview.chromium.org/9480001/diff/1/client/dom/scripts/systemnative...
client/dom/scripts/systemnative.py:750: if
idl_argument.ext_attrs.get('Optional') == 'DefaultIsNullString':
On 2012/02/27 15:59:36, antonm wrote:
> On 2012/02/27 15:53:48, podivilov wrote:
> > This code is not actually used, do we really want to keep it?
> 
> Why it's not used?  It's need, e.g., to make (most probably slightly
incorrect)
> test to pass

Ok, seems like it is used for constructor parameters.