Issue 9479004: Add a stubbed-out implementation of FlowGraphCompiler for ia32 and arm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9479004: Add a stubbed-out implementation of FlowGraphCompiler for ia32 and arm. (Closed)

Created:
8 years, 9 months ago by Kevin Millikin (Google)

Modified:
8 years, 9 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Add a stubbed-out implementation of FlowGraphCompiler for ia32 and arm. It bails out if FlowGraphCompiler::CompileGraph is called, all other public API functions are UNIMPLEMENTED. R=srdjan@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4685

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+322 lines, -77 lines)			Patch
M	runtime/vm/code_generator_ia32.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/code_generator_x64.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/code_generator_x64.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/compiler.cc	View	4 chunks	+72 lines, -58 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.h	View	1 chunk	+6 lines, -2 lines	0 comments	Download
A	runtime/vm/flow_graph_compiler_arm.h	View	1 chunk	+51 lines, -0 lines	0 comments	Download
A	runtime/vm/flow_graph_compiler_arm.cc	View	1 chunk	+48 lines, -0 lines	0 comments	Download
A	runtime/vm/flow_graph_compiler_ia32.h	View	1 chunk	+51 lines, -0 lines	0 comments	Download
A	runtime/vm/flow_graph_compiler_ia32.cc	View	1 chunk	+48 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	3 chunks	+24 lines, -12 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Kevin Millikin (Google)

This includes the changes from http://codereview.chromium.org/9474001/ which will be landed first (it doesn't really depend ...

8 years, 9 months ago (2012-02-27 15:53:37 UTC) #1

LGTM