Make FileInputStream and FileOutputStream actually asynchronous.

Make FileInputStream and FileOutputStream actually asynchronous.

Use the async API of the underlying file.

This also means that openInputStream and openOutputStream can
directly return the stream without performing IO. I'll do that
change as a follow-up.

R=sgjesse@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=4662

[Søren Gjesse, 2012-02-28 07:40:25]

lgtm

http://codereview.chromium.org/9474004/diff/1001/runtime/bin/chunked_stream.dart
File runtime/bin/chunked_stream.dart (right):

http://codereview.chromium.org/9474004/diff/1001/runtime/bin/chunked_stream.d...
runtime/bin/chunked_stream.dart:125: if (_scheduledDataCallback != null) {
Woops!

http://codereview.chromium.org/9474004/diff/1001/runtime/bin/file_impl.dart
File runtime/bin/file_impl.dart (right):

http://codereview.chromium.org/9474004/diff/1001/runtime/bin/file_impl.dart#n...
runtime/bin/file_impl.dart:35: openedFile.length();
What is length when the file is stdin?

http://codereview.chromium.org/9474004/diff/1001/runtime/bin/file_impl.dart#n...
runtime/bin/file_impl.dart:145: return false;
We should probably revisit whether write and writeFrom should have boolean
return type.

http://codereview.chromium.org/9474004/diff/1001/runtime/bin/file_impl.dart#n...
runtime/bin/file_impl.dart:519: void openInputStream() {
So you kept the Sync/non Sync versions for now?

http://codereview.chromium.org/9474004/diff/1001/tests/standalone/src/FileInp...
File tests/standalone/src/FileInputStreamTest.dart (right):

http://codereview.chromium.org/9474004/diff/1001/tests/standalone/src/FileInp...
tests/standalone/src/FileInputStreamTest.dart:74: x.chunkSize = 5;
I guess that this test is actually wrong, as the data handler callback only
ensures that 9 bytes are available. The additional reads should be in a new data
handler callback.

http://codereview.chromium.org/9474004/diff/1001/tests/standalone/src/FileTes...
File tests/standalone/src/FileTest.dart (right):

http://codereview.chromium.org/9474004/diff/1001/tests/standalone/src/FileTes...
tests/standalone/src/FileTest.dart:327: OutputStream appendingOutput =
file2.openOutputStreamSync(FileMode.APPEND);
Long line.

http://codereview.chromium.org/9474004/diff/1001/tests/standalone/src/TimerCa...
File tests/standalone/src/TimerCancelTest.dart (right):

http://codereview.chromium.org/9474004/diff/1001/tests/standalone/src/TimerCa...
tests/standalone/src/TimerCancelTest.dart:34: var t2;
Does the API specify that timers with the same timeout will be processed in
creation order? Also in some cases the two timers will probably not get the same
timeout, as the wall time have advanced when t2 is created.

[Søren Gjesse, 2012-02-28 08:10:26]

http://codereview.chromium.org/9474004/diff/1001/runtime/bin/file_impl.dart
File runtime/bin/file_impl.dart (right):

http://codereview.chromium.org/9474004/diff/1001/runtime/bin/file_impl.dart#n...
runtime/bin/file_impl.dart:35: openedFile.length();
On 2012/02/28 07:40:25, Søren Gjesse wrote:
> What is length when the file is stdin?

This is correct. I forgot that the constructor _FileInputStream.fromStdio is
used when stdin is redirected from a file and the file descriptor is for an open
file - not a pipe.

[Mads Ager (google), 2012-02-28 08:21:00]

http://codereview.chromium.org/9474004/diff/1001/runtime/bin/file_impl.dart
File runtime/bin/file_impl.dart (right):

http://codereview.chromium.org/9474004/diff/1001/runtime/bin/file_impl.dart#n...
runtime/bin/file_impl.dart:145: return false;
On 2012/02/28 07:40:25, Søren Gjesse wrote:
> We should probably revisit whether write and writeFrom should have boolean
> return type.

Agreed, we probably should.

http://codereview.chromium.org/9474004/diff/1001/runtime/bin/file_impl.dart#n...
runtime/bin/file_impl.dart:519: void openInputStream() {
On 2012/02/28 07:40:25, Søren Gjesse wrote:
> So you kept the Sync/non Sync versions for now?

Yes, I will do a follow-up change today to get rid of that again. :)

http://codereview.chromium.org/9474004/diff/1001/tests/standalone/src/FileInp...
File tests/standalone/src/FileInputStreamTest.dart (right):

http://codereview.chromium.org/9474004/diff/1001/tests/standalone/src/FileInp...
tests/standalone/src/FileInputStreamTest.dart:74: x.chunkSize = 5;
On 2012/02/28 07:40:25, Søren Gjesse wrote:
> I guess that this test is actually wrong, as the data handler callback only
> ensures that 9 bytes are available. The additional reads should be in a new
data
> handler callback.

Thanks. Done.

http://codereview.chromium.org/9474004/diff/1001/tests/standalone/src/FileTes...
File tests/standalone/src/FileTest.dart (right):

http://codereview.chromium.org/9474004/diff/1001/tests/standalone/src/FileTes...
tests/standalone/src/FileTest.dart:327: OutputStream appendingOutput =
file2.openOutputStreamSync(FileMode.APPEND);
On 2012/02/28 07:40:25, Søren Gjesse wrote:
> Long line.

Done.

http://codereview.chromium.org/9474004/diff/1001/tests/standalone/src/TimerCa...
File tests/standalone/src/TimerCancelTest.dart (right):

http://codereview.chromium.org/9474004/diff/1001/tests/standalone/src/TimerCa...
tests/standalone/src/TimerCancelTest.dart:34: var t2;
On 2012/02/28 07:40:25, Søren Gjesse wrote:
> Does the API specify that timers with the same timeout will be processed in
> creation order? Also in some cases the two timers will probably not get the
same
> timeout, as the wall time have advanced when t2 is created.

Good point. I have changed the test so the timer that fires first cancels the
other timer.