Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 9466041: Removes dependency on v8 from dartc testing (Closed)

Created:
8 years, 10 months ago by zundel
Modified:
8 years, 10 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, ahe, danrubel
Visibility:
Public.

Description

Removes dependency on d8/v8 from dartc Committed: https://code.google.com/p/dart/source/detail?r=4616

Patch Set 1 #

Total comments: 15

Patch Set 2 : Updated date, copyright notices, build.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -904 lines) Patch
M compiler/build.xml View 1 4 chunks +8 lines, -14 lines 0 comments Download
M compiler/dart-compiler.gyp View 1 5 chunks +1 line, -25 lines 0 comments Download
M compiler/dartc.xml View 1 4 chunks +5 lines, -12 lines 0 comments Download
M compiler/java/com/google/dart/compiler/CommandLineOptions.java View 2 chunks +0 lines, -45 lines 0 comments Download
M compiler/java/com/google/dart/compiler/UnitTestBatchRunner.java View 1 1 chunk +2 lines, -4 lines 0 comments Download
D compiler/java/com/google/dart/runner/BundleLibrarySource.java View 1 chunk +0 lines, -62 lines 0 comments Download
D compiler/java/com/google/dart/runner/DartRunner.java View 1 chunk +0 lines, -301 lines 0 comments Download
D compiler/java/com/google/dart/runner/JavaScriptLauncher.java View 1 chunk +0 lines, -15 lines 0 comments Download
D compiler/java/com/google/dart/runner/RunnerError.java View 1 chunk +0 lines, -19 lines 0 comments Download
D compiler/java/com/google/dart/runner/RunnerOptions.java View 1 chunk +0 lines, -19 lines 0 comments Download
D compiler/java/com/google/dart/runner/V8Launcher.java View 1 chunk +0 lines, -178 lines 0 comments Download
A compiler/javatests/com/google/dart/compiler/AnalysisError.java View 1 chunk +19 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/corelib/SharedTestCase.java View 1 6 chunks +7 lines, -14 lines 0 comments Download
M compiler/javatests/com/google/dart/corelib/SharedTests.java View 1 3 chunks +1 line, -8 lines 0 comments Download
D compiler/javatests/com/google/dart/runner/AllTests.java View 1 chunk +0 lines, -18 lines 0 comments Download
D compiler/javatests/com/google/dart/runner/DartRunnerTest.java View 1 chunk +0 lines, -22 lines 0 comments Download
M compiler/scripts/dartc_run.sh View 1 3 chunks +3 lines, -6 lines 0 comments Download
D compiler/scripts/dartc_size.sh View 1 chunk +0 lines, -92 lines 0 comments Download
D compiler/scripts/dartc_test.sh View 1 chunk +0 lines, -39 lines 0 comments Download
M compiler/scripts/dartc_wrapper.py View 1 2 chunks +2 lines, -10 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
zundel
The test framework now just calls dartc wrapper directly instead of the dartc_test wrapper, since ...
8 years, 10 months ago (2012-02-26 15:13:07 UTC) #1
ahe
LGTM! Summary of comments: update copyright year and don't forget build.xml. Cheers, Peter http://codereview.chromium.org/9466041/diff/1/compiler/dart-compiler.gyp File ...
8 years, 10 months ago (2012-02-27 06:33:21 UTC) #2
zundel
Updated patch http://codereview.chromium.org/9466041/diff/1/compiler/dart-compiler.gyp File compiler/dart-compiler.gyp (right): http://codereview.chromium.org/9466041/diff/1/compiler/dart-compiler.gyp#newcode1 compiler/dart-compiler.gyp:1: # Copyright (c) 2011, the Dart project ...
8 years, 10 months ago (2012-02-27 07:31:11 UTC) #3
scheglov
8 years, 10 months ago (2012-02-27 14:18:04 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698