Issue 9466030: Fixing bugs: 1612, 1843, 1847

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9466030: Fixing bugs: 1612, 1843, 1847 (Closed)

Created:
8 years, 10 months ago by hausner

Modified:
8 years, 10 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fixing bugs: 1612, 1843, 1847 - Fix error location when referring to types in object allocation. - Handle CR/LF correctly at beginning of source. - Detect duplicate identifier in typedef declaration. Committed: https://code.google.com/p/dart/source/detail?r=4584

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -23 lines)			Patch
	M	runtime/vm/parser.cc	View	1	6 chunks	+24 lines, -20 lines	0 comments	Download
	M	runtime/vm/scanner.cc	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages