Issue 9466013: Issue 1129. Report #import errors after parsing, so after "unitAboutToCompile".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9466013: Issue 1129. Report #import errors after parsing, so after "unitAboutToCompile". (Closed)

Created:
8 years, 10 months ago by scheglov

Modified:
8 years, 10 months ago

Reviewers:
devoncarew, zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 1129. Report #import errors after parsing, so after "unitAboutToCompile". http://code.google.com/p/dart/issues/detail?id=1129 R=zundel@google.com,devoncarew@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4579

Patch Set 1 #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -15 lines)			Patch
	M	compiler/java/com/google/dart/compiler/DartCompiler.java	View		5 chunks	+38 lines, -12 lines	0 comments	Download
	M	compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java	View		4 chunks	+40 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zundel

8 years, 10 months ago (2012-02-24 19:48:39 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/9466013/diff/1/compiler/javatests/com/...
File
compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java
(right):

https://chromiumcodereview.appspot.com/9466013/diff/1/compiler/javatests/com/...
compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java:539:
// XXX
fill in comment

Expand Messages | Collapse Messages