Issue 9466008: Use the component information when the test is being scheduled instead of when it's being created.

Issue 9466008: Use the component information when the test is being scheduled instead of when it's being created. (Closed)

Created:
8 years, 10 months ago by ngeoffray

Modified:
8 years, 10 months ago

Reviewers:
Bill Hesse, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, ahe, Siggi Cherem (dart-lang)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Use the component information when the test is being scheduled instead of when it's being created. Committed: https://code.google.com/p/dart/source/detail?r=4572

Patch Set 3 : #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -15 lines)			Patch
	M	tools/testing/dart/multitest.dart	View		2 chunks	+7 lines, -4 lines	2 comments	Download
	M	tools/testing/dart/test_suite.dart	View	1 2	3 chunks	+25 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

LGTM. https://chromiumcodereview.appspot.com/9466008/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://chromiumcodereview.appspot.com/9466008/diff/1/tools/testing/dart/test_suite.dart#newcode303 tools/testing/dart/test_suite.dart:303: } I think this could be moved to ...

8 years, 10 months ago (2012-02-24 13:58:36 UTC) #2

ngeoffray

Thanks Bill for the review. https://chromiumcodereview.appspot.com/9466008/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://chromiumcodereview.appspot.com/9466008/diff/1/tools/testing/dart/test_suite.dart#newcode303 tools/testing/dart/test_suite.dart:303: } On 2012/02/24 13:58:36, ...

8 years, 10 months ago (2012-02-24 14:08:09 UTC) #3

Siggi Cherem (dart-lang)

lgtm. Cool! thanks for the quick fix Nicolas! https://chromiumcodereview.appspot.com/9466008/diff/4003/tools/testing/dart/multitest.dart File tools/testing/dart/multitest.dart (right): https://chromiumcodereview.appspot.com/9466008/diff/4003/tools/testing/dart/multitest.dart#newcode120 tools/testing/dart/multitest.dart:120: String ...

8 years, 10 months ago (2012-02-24 19:18:52 UTC) #4

ngeoffray

8 years, 10 months ago (2012-02-27 09:08:03 UTC) #5

https://chromiumcodereview.appspot.com/9466008/diff/4003/tools/testing/dart/m...
File tools/testing/dart/multitest.dart (right):

https://chromiumcodereview.appspot.com/9466008/diff/4003/tools/testing/dart/m...
tools/testing/dart/multitest.dart:120: String component,
On 2012/02/24 19:18:52, sigmund wrote:
> seems like this arg might not be necessary anymore

Good point. Removed in https://chromiumcodereview.appspot.com/9463047/

Expand Messages | Collapse Messages