Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 9465023: Fix escaping in JSON.stringify and add unit test (Closed)

Created:
8 years, 10 months ago by Dan Rice
Modified:
8 years, 10 months ago
Reviewers:
Anton Muhin, antonm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix escaping in JSON.stringify and add unit test BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4622

Patch Set 1 #

Patch Set 2 : Import dart:json, break out test function #

Patch Set 3 : Fix a stray LINE_FEED reference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -19 lines) Patch
M lib/json/json.dart View 1 2 5 chunks +40 lines, -19 lines 0 comments Download
A tests/utils/src/JsonTest.dart View 1 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
antonm
LGTM!
8 years, 10 months ago (2012-02-27 16:01:36 UTC) #1
Dan Rice
8 years, 10 months ago (2012-02-27 16:11:32 UTC) #2
On 2012/02/27 16:01:36, antonm wrote:
> LGTM!

Thanks for the speedy review.

Powered by Google App Engine
This is Rietveld 408576698