Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 9464044: Updates incremental compilation tests to work w/o code generation (Closed)

Created:
8 years, 10 months ago by zundel
Modified:
8 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, danrubel, mmendez
Visibility:
Public.

Description

Updates incremental compilation tests to work w/o code generation Removes end2end tests that presume code generation Committed: https://code.google.com/p/dart/source/detail?r=4592

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -892 lines) Patch
M compiler/java/com/google/dart/compiler/DartCompiler.java View 9 chunks +48 lines, -24 lines 0 comments Download
M compiler/java/com/google/dart/compiler/backend/js/JavascriptBackend.java View 4 chunks +7 lines, -9 lines 0 comments Download
M compiler/java/com/google/dart/compiler/metrics/DartEventType.java View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/DeltaBench.java View 1 chunk +0 lines, -5 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/MockArtifactProvider.java View 1 chunk +1 line, -1 line 1 comment Download
D compiler/javatests/com/google/dart/compiler/end2end/BasicTest.dart View 1 chunk +0 lines, -6 lines 0 comments Download
D compiler/javatests/com/google/dart/compiler/end2end/BasicTest.java View 1 chunk +0 lines, -15 lines 0 comments Download
D compiler/javatests/com/google/dart/compiler/end2end/BasicTest_app.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D compiler/javatests/com/google/dart/compiler/end2end/End2EndTestCase.java View 1 chunk +0 lines, -152 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/End2EndTests.java View 2 chunks +1 line, -4 lines 0 comments Download
D compiler/javatests/com/google/dart/compiler/end2end/MainMethodTest.java View 1 chunk +0 lines, -130 lines 0 comments Download
D compiler/javatests/com/google/dart/compiler/end2end/NamedParameterTest.dart View 1 chunk +0 lines, -236 lines 0 comments Download
D compiler/javatests/com/google/dart/compiler/end2end/NamedParameterTest.java View 1 chunk +0 lines, -57 lines 0 comments Download
D compiler/javatests/com/google/dart/compiler/end2end/RedirectedConstructorTest.dart View 1 chunk +0 lines, -26 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java View 15 chunks +30 lines, -41 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationTest.java View 22 chunks +133 lines, -162 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationWithPrefixTest.java View 4 chunks +8 lines, -19 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
zundel
This fix was on my list of "TODOs" before removing the backend. The tests I ...
8 years, 10 months ago (2012-02-25 21:08:01 UTC) #1
scheglov
8 years, 10 months ago (2012-02-25 21:47:17 UTC) #2
LGTM

http://codereview.chromium.org/9464044/diff/1/compiler/javatests/com/google/d...
File compiler/javatests/com/google/dart/compiler/MockArtifactProvider.java
(right):

http://codereview.chromium.org/9464044/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/MockArtifactProvider.java:79:
Artifact found = artifacts.remove(keyFor(name, part, ext));
unused assignment

http://codereview.chromium.org/9464044/diff/1/compiler/javatests/com/google/d...
File
compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationWithPrefixTest.java
(right):

http://codereview.chromium.org/9464044/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationWithPrefixTest.java:122:
// didWrite("my.prefixed.app.dart", EXTENSION_APP_JS);
why not remove?

Powered by Google App Engine
This is Rietveld 408576698