Added LoadLiteralComp, StrictCompareComp; implement InstanceCallNode.

Added LoadLiteralComp, StrictCompareComp; implement InstanceCallNode.
Committed: https://code.google.com/p/dart/source/detail?r=4580

[Kevin Millikin (Google), 2012-02-24 10:53:04]

Remove LoadLiteralComp and the changes to VisitLiteralNode functions.  We can
continue to iterate on the design for those.

The rest all LGTM.

https://chromiumcodereview.appspot.com/9456033/diff/1003/runtime/vm/flow_grap...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/9456033/diff/1003/runtime/vm/flow_grap...
runtime/vm/flow_graph_builder.cc:192: new LoadLiteralComp(new
ConstantValue(node->literal()));
As mentioned: let's not materialize literals in all contexts, but only those
that will need it.

https://chromiumcodereview.appspot.com/9456033/diff/1003/runtime/vm/intermedi...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/9456033/diff/1003/runtime/vm/intermedi...
runtime/vm/intermediate_language.h:24: //                 | LoadLiteral
<Instance>
Class has LoadLiteral <Value>.  The grammar and the classes should agree, but we
need to hash out how we do this a bit more.

https://chromiumcodereview.appspot.com/9456033/diff/1003/runtime/vm/intermedi...
runtime/vm/intermediate_language.h:26: //                 | StrictCompare
<Token::kind> <Value> ...
This one has only two Value subparts, so let's write

StringCompare <Token::Kind> <Value> <Value>

[srdjan, 2012-02-24 22:16:24]

https://chromiumcodereview.appspot.com/9456033/diff/1003/runtime/vm/flow_grap...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/9456033/diff/1003/runtime/vm/flow_grap...
runtime/vm/flow_graph_builder.cc:192: new LoadLiteralComp(new
ConstantValue(node->literal()));
On 2012/02/24 10:53:04, kmillikin wrote:
> As mentioned: let's not materialize literals in all contexts, but only those
> that will need it.

OK, let's see how it works out.

https://chromiumcodereview.appspot.com/9456033/diff/1003/runtime/vm/intermedi...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/9456033/diff/1003/runtime/vm/intermedi...
runtime/vm/intermediate_language.h:24: //                 | LoadLiteral
<Instance>
On 2012/02/24 10:53:04, kmillikin wrote:
> Class has LoadLiteral <Value>.  The grammar and the classes should agree, but
we
> need to hash out how we do this a bit more.

LoadLiteral has been removed

https://chromiumcodereview.appspot.com/9456033/diff/1003/runtime/vm/intermedi...
runtime/vm/intermediate_language.h:26: //                 | StrictCompare
<Token::kind> <Value> ...
On 2012/02/24 10:53:04, kmillikin wrote:
> This one has only two Value subparts, so let's write
> 
> StringCompare <Token::Kind> <Value> <Value>

Done.