Issue 9456017: Fix issue 1741: add map to immutable list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9456017: Fix issue 1741: add map to immutable list. (Closed)

Created:
8 years, 10 months ago by srdjan

Modified:
8 years, 10 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix issue 1741: add map to immutable list. Committed: https://code.google.com/p/dart/source/detail?r=4548

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	runtime/lib/array.dart	View		1 chunk	+4 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://chromiumcodereview.appspot.com/9456017/diff/1/runtime/lib/array.dart File runtime/lib/array.dart (right): https://chromiumcodereview.appspot.com/9456017/diff/1/runtime/lib/array.dart#newcode222 runtime/lib/array.dart:222: Not for this change list but maybe a ...

8 years, 10 months ago (2012-02-23 19:11:46 UTC) #2

srdjan

8 years, 10 months ago (2012-02-23 19:23:23 UTC) #3

https://chromiumcodereview.appspot.com/9456017/diff/1/runtime/lib/array.dart
File runtime/lib/array.dart (right):

https://chromiumcodereview.appspot.com/9456017/diff/1/runtime/lib/array.dart#...
runtime/lib/array.dart:222: 
On 2012/02/23 19:11:46, asiva wrote:
> Not for this change list but maybe a future refactor:
> 
> There seem to be a number of functions between ImmutableArray and ObjectArray
> which are identical. Maybe we can have a baseclass which implements all these
> common methods and ObjectArray and ImmutableArray can be derived from this
base
> class.

We need mixins :-). Having subclass hierarchies just for code reuse is wrong,
AFAIK.

Expand Messages | Collapse Messages