Issue 9456009: Fix a pair of bugs in the translation of 'if' nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9456009: Fix a pair of bugs in the translation of 'if' nodes. (Closed)

Created:
8 years, 10 months ago by Kevin Millikin (Google)

Modified:
8 years, 10 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix a pair of bugs in the translation of 'if' nodes. The condition graph fragment was appended twice, and the join did not properly handle the case of nonlocal exits from the arms of the 'if'. R=srdjan@google.com BUG= TEST=all tests pass in x64 release mode with --use_new_compiler Committed: https://code.google.com/p/dart/source/detail?r=4545

Patch Set 1 #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	runtime/vm/flow_graph_builder.cc	View		3 chunks	+9 lines, -3 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

8 years, 10 months ago (2012-02-23 16:27:22 UTC) #3

https://chromiumcodereview.appspot.com/9456009/diff/1/runtime/vm/flow_graph_b...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/9456009/diff/1/runtime/vm/flow_graph_b...
runtime/vm/flow_graph_builder.cc:68: false_fragment.is_empty() ? false_entry :
false_fragment.exit();
When can false_exit and true_exit be NULL, i.e., when can
false/true_fragment.exit() be NULL?

Expand Messages | Collapse Messages