Issue 9455090: Support optional callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9455090: Support optional callbacks. (Closed)

Created:
8 years, 10 months ago by antonm

Modified:
8 years, 10 months ago

Reviewers:
podivilov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support optional callbacks. Committed: https://code.google.com/p/dart/source/detail?r=4620

Patch Set 2 : Addressing Pavel's comments #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -12 lines)			Patch
	M	client/dom/scripts/systemnative.py	View		2 chunks	+3 lines, -12 lines	0 comments	Download
	M	client/dom/scripts/systemwrapping.py	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

podivilov

lgtm https://chromiumcodereview.appspot.com/9455090/diff/1/client/dom/scripts/systemnative.py File client/dom/scripts/systemnative.py (right): https://chromiumcodereview.appspot.com/9455090/diff/1/client/dom/scripts/systemnative.py#newcode728 client/dom/scripts/systemnative.py:728: flags = '' adapter_arguments = [...]? https://chromiumcodereview.appspot.com/9455090/diff/1/client/dom/scripts/systemwrapping.py File ...

8 years, 10 months ago (2012-02-27 14:44:53 UTC) #2

antonm

8 years, 10 months ago (2012-02-27 15:25:02 UTC) #3

https://chromiumcodereview.appspot.com/9455090/diff/1/client/dom/scripts/syst...
File client/dom/scripts/systemnative.py (right):

https://chromiumcodereview.appspot.com/9455090/diff/1/client/dom/scripts/syst...
client/dom/scripts/systemnative.py:728: flags = ''
On 2012/02/27 14:44:53, podivilov wrote:
> adapter_arguments = [...]?

As discussed offline, let's come to this later.

https://chromiumcodereview.appspot.com/9455090/diff/1/client/dom/scripts/syst...
File client/dom/scripts/systemwrapping.py (right):

https://chromiumcodereview.appspot.com/9455090/diff/1/client/dom/scripts/syst...
client/dom/scripts/systemwrapping.py:460: # instead of missing arguments.  That
means that's the only allowed form is a list of
On 2012/02/27 14:44:53, podivilov wrote:
> nit: remove "that's"

Done.

Expand Messages | Collapse Messages

Issue 9455090: Support optional callbacks. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressing Pavel's comments #

Messages