Issue 9454015: updated comments and usage string in frogpad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9454015: updated comments and usage string in frogpad (Closed)

Created:
8 years, 10 months ago by mattsh

Modified:
8 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang), Emily Fortuna, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

improved comments BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4543

Patch Set 2 : prints better help message #

Patch Set 4 : small fix #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -24 lines)			Patch
	M	tools/testing/frogpad/frogpad.py	View	1 2 3	9 chunks	+35 lines, -24 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm https://chromiumcodereview.appspot.com/9454015/diff/3001/tools/testing/frogpad/frogpad.py File tools/testing/frogpad/frogpad.py (right): https://chromiumcodereview.appspot.com/9454015/diff/3001/tools/testing/frogpad/frogpad.py#newcode104 tools/testing/frogpad/frogpad.py:104: Extra line?

8 years, 10 months ago (2012-02-23 17:05:10 UTC) #2

mattsh

https://chromiumcodereview.appspot.com/9454015/diff/3001/tools/testing/frogpad/frogpad.py File tools/testing/frogpad/frogpad.py (right): https://chromiumcodereview.appspot.com/9454015/diff/3001/tools/testing/frogpad/frogpad.py#newcode104 tools/testing/frogpad/frogpad.py:104: On 2012/02/23 17:05:10, Emily Fortuna wrote: > Extra line? ...

8 years, 10 months ago (2012-02-23 17:27:09 UTC) #3

Siggi Cherem (dart-lang)

8 years, 10 months ago (2012-02-23 20:57:22 UTC) #4

lgtm

https://chromiumcodereview.appspot.com/9454015/diff/6001/tools/testing/frogpa...
File tools/testing/frogpad/frogpad.py (right):

https://chromiumcodereview.appspot.com/9454015/diff/6001/tools/testing/frogpa...
tools/testing/frogpad/frogpad.py:108: OUTPUT_JAVASCRIPT_REGEX =
re.compile(".*\nOutput:(.*)#EOF", re.DOTALL)
possibly add a '\n' after ':' also?