Issue 9454014: Support named parameters for super initializers and redirections.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9454014: Support named parameters for super initializers and redirections. (Closed)

Created:
8 years, 10 months ago by karlklose

Modified:
8 years, 10 months ago

Reviewers:
floitsch, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support named parameters for super initializers and redirections. Committed: https://code.google.com/p/dart/source/detail?r=4606

Patch Set 1 #

Patch Set 2 : Fix signature. #

Patch Set 3 : Add test. #

Patch Set 4 : Use addStaticSendArguments. #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -32 lines)			Patch
M	frog/leg/resolver.dart	View	1 2 3	3 chunks	+11 lines, -9 lines	1 comment	Download
M	frog/leg/ssa/builder.dart	View	1 2 3	2 chunks	+7 lines, -23 lines	0 comments	Download
A	tests/language/src/ConstructorNamedArgumentsTest.dart	View	1 2 3	1 chunk	+52 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

8 years, 10 months ago (2012-02-24 13:43:01 UTC) #2

LGTM! Thanks for the refactoring.

http://codereview.chromium.org/9454014/diff/5001/frog/leg/resolver.dart
File frog/leg/resolver.dart (right):

http://codereview.chromium.org/9454014/diff/5001/frog/leg/resolver.dart#newco...
frog/leg/resolver.dart:372: // Resolve the arguments of the call to get a
selector.
This is not just for getting a selector, but also resolving the arguments. Maybe
improve the comment by saying:
// Resolve the arguments, and make sure the call gets a selector, by calling
handleArguments.

Expand Messages | Collapse Messages