frogpad now invokes DumpRenderTree

frogpad now invokes DumpRenderTree


BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=4513

[Jennifer Messerly, 2012-02-23 03:24:48]

lgtm

https://chromiumcodereview.appspot.com/9454004/diff/1/tools/testing/frogpad/f...
File tools/testing/frogpad/frogpad.py (right):

https://chromiumcodereview.appspot.com/9454004/diff/1/tools/testing/frogpad/f...
tools/testing/frogpad/frogpad.py:250: args = []
  args = [drt, self.html_file]
or just:
  stdout = run_command([drt, self.html_file])

[mattsh, 2012-02-23 04:13:03]

https://chromiumcodereview.appspot.com/9454004/diff/1/tools/testing/frogpad/f...
File tools/testing/frogpad/frogpad.py (right):

https://chromiumcodereview.appspot.com/9454004/diff/1/tools/testing/frogpad/f...
tools/testing/frogpad/frogpad.py:250: args = []
On 2012/02/23 03:24:49, John Messerly wrote:
>   args = [drt, self.html_file]
> or just:
>   stdout = run_command([drt, self.html_file])

Actually I think I kind of like it this way in case there are more args (and
it's parallel to how it's done above where there really are more args)

[Siggi Cherem (dart-lang), 2012-02-23 16:43:26]

https://chromiumcodereview.appspot.com/9454004/diff/1/tools/testing/frogpad/f...
File tools/testing/frogpad/frogpad.py (right):

https://chromiumcodereview.appspot.com/9454004/diff/1/tools/testing/frogpad/f...
tools/testing/frogpad/frogpad.py:95: {{FROGPAD_JS}}
note that this approach works ok on any code that doesn't use isolates. For
isolates (e.g. spawning a worker) you'll need to have a src url.

https://chromiumcodereview.appspot.com/9454004/diff/1/tools/testing/frogpad/f...
tools/testing/frogpad/frogpad.py:250: args = []
On 2012/02/23 04:13:03, mattsh wrote:
> On 2012/02/23 03:24:49, John Messerly wrote:
> >   args = [drt, self.html_file]
> > or just:
> >   stdout = run_command([drt, self.html_file])
> 
> Actually I think I kind of like it this way in case there are more args (and
> it's parallel to how it's done above where there really are more args)

a pattern I've seen so far is to use inline lists unless you have a conditional
append. So even above it could be:
args = [
    dart_vm,
    "--enable_asserts",
    "--libdir=%s/lib" % self.frog_dir",
    ...
    frogpad_dart
  ]
run_command(args)

https://chromiumcodereview.appspot.com/9454004/diff/1/tools/testing/frogpad/f...
tools/testing/frogpad/frogpad.py:255: match = re.match("(?s).*Output:(.*)#EOF",
stdout)
I think it is better to check that 'Output:' is at the beginning of the line,
otherwise this can match in many other places. I don't know about how this is
done in a single regexp, if you do a line-by-line scan of the output, I believe
you can check for:
  re.match("^Output:$", line)

[Emily Fortuna, 2012-02-23 21:38:50]

https://chromiumcodereview.appspot.com/9454004/diff/1/tools/testing/frogpad/f...
File tools/testing/frogpad/frogpad.py (right):

https://chromiumcodereview.appspot.com/9454004/diff/1/tools/testing/frogpad/f...
tools/testing/frogpad/frogpad.py:255: match = re.match("(?s).*Output:(.*)#EOF",
stdout)
On 2012/02/23 16:43:26, sigmund wrote:
> I think it is better to check that 'Output:' is at the beginning of the line,
> otherwise this can match in many other places. I don't know about how this is
> done in a single regexp, if you do a line-by-line scan of the output, I
believe
> you can check for:
>   re.match("^Output:$", line)

+1

https://chromiumcodereview.appspot.com/9454004/diff/1/tools/testing/frogpad/f...
tools/testing/frogpad/frogpad.py:257: raise Exception("can't find regex in
DumpRenderTree output")
Possibly print the regex you were looking for in this error message to make our
errors more helpful?