Issue 9453031: Make dartdoc and apidoc run on the VM instead of node.

Issue 9453031: Make dartdoc and apidoc run on the VM instead of node. (Closed)

Created:
8 years, 10 months ago by Bob Nystrom

Modified:
8 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang), Ivan Posva

CC:
reviews_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make dartdoc and apidoc run on the VM instead of node. Committed: https://code.google.com/p/dart/source/detail?r=4558

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -17 lines)			Patch
M	utils/apidoc/apidoc	View	1 chunk	+9 lines, -1 line	0 comments	Download
M	utils/apidoc/apidoc.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	utils/apidoc/html_diff.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/dartdoc/comment_map.dart	View	1 chunk	+1 line, -1 line	2 comments	Download
M	utils/dartdoc/dartdoc	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	utils/dartdoc/dartdoc.dart	View	5 chunks	+15 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

The code for detecting the path to the dart executable is kind of nasty. If ...

8 years, 10 months ago (2012-02-23 23:04:25 UTC) #1

Siggi Cherem (dart-lang)

lgtm https://chromiumcodereview.appspot.com/9453031/diff/1/utils/dartdoc/comment_map.dart File utils/dartdoc/comment_map.dart (left): https://chromiumcodereview.appspot.com/9453031/diff/1/utils/dartdoc/comment_map.dart#oldcode105 utils/dartdoc/comment_map.dart:105: for (final line in comment.split('\n')) { wow... if ...

8 years, 10 months ago (2012-02-23 23:15:47 UTC) #2

Bob Nystrom

Thanks! https://chromiumcodereview.appspot.com/9453031/diff/1/utils/dartdoc/comment_map.dart File utils/dartdoc/comment_map.dart (left): https://chromiumcodereview.appspot.com/9453031/diff/1/utils/dartdoc/comment_map.dart#oldcode105 utils/dartdoc/comment_map.dart:105: for (final line in comment.split('\n')) { On 2012/02/23 ...

8 years, 10 months ago (2012-02-23 23:54:38 UTC) #3

Thanks! LGTM!

-Ivan

Expand Messages | Collapse Messages