Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 9453030: Fix for issue 1814 for dart:dom (Closed)

Created:
8 years, 10 months ago by sra1
Modified:
8 years, 10 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, sethladd
Visibility:
Public.

Description

Fix for issue 1814 for dart:dom Emit canned native bodies as a work-around for Issue 1814. A better solution is to support the alternate name directly - then the compiler can specialize the call site and avoid testing argument values to determine the number of parameters. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4557

Patch Set 1 #

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -25 lines) Patch
M client/dom/frog/dom_frog.dart View 1 11 chunks +30 lines, -11 lines 0 comments Download
M client/dom/generated/src/frog/Float32Array.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/Float64Array.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/IDBCursor.dart View 1 chunk +4 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/IDBIndex.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/frog/IDBObjectStore.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/frog/Int16Array.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/Int32Array.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/Int8Array.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/Uint16Array.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/Uint32Array.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/Uint8Array.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M client/dom/scripts/generator.py View 1 1 chunk +30 lines, -0 lines 0 comments Download
M client/dom/scripts/systemfrog.py View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
8 years, 10 months ago (2012-02-23 22:48:16 UTC) #1
vsm
8 years, 10 months ago (2012-02-23 23:26:58 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698