Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 9453014: Implement a simple InstructionVisitor class. (Closed)

Created:
8 years, 10 months ago by Kevin Millikin (Google)
Modified:
8 years, 10 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implement a simple InstructionVisitor class. The instruction visitor visits each block and for each block each instruction. Rewrite the instruction printing code to use this new visitor. R=srdjan@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4547

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -98 lines) Patch
M runtime/vm/flow_graph_builder.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 2 chunks +75 lines, -11 lines 0 comments Download
M runtime/vm/intermediate_language.h View 5 chunks +143 lines, -58 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 2 chunks +36 lines, -27 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
This is based on http://codereview.chromium.org/9454012/ and includes the code from that change (sorry: I didn't ...
8 years, 10 months ago (2012-02-23 15:46:29 UTC) #1
srdjan
On 2012/02/23 15:46:29, kmillikin wrote: > This is based on http://codereview.chromium.org/9454012/ and includes the code ...
8 years, 10 months ago (2012-02-23 16:53:34 UTC) #2
srdjan
8 years, 10 months ago (2012-02-23 16:53:52 UTC) #3
LGTM after addressing the issues in http://codereview.chromium.org/9454012/

Powered by Google App Engine
This is Rietveld 408576698