Put two $ in front of top-level builtins, to not clash with member names. Otherwise, the global obj…

Put two $ in front of top-level builtins, to not clash with member names. Otherwise, the global object calls the top-level builtin instead of its member.
Committed: https://code.google.com/p/dart/source/detail?r=4564

[floitsch, 2012-02-24 11:42:23]

LGTM.

[sra1, 2012-02-24 19:36:07]

This is a broken fix.

The Frog name mangling rule is that $ in a user identifier is always doubled-up
to $$.
I think you could write this in Dart and get a clash:
   void $eq(){}

The $-->$$ mangling means
  (1) a single $ is always safe for a non-user identifier (like builtings and
argument defaulting trampoline),
  (2) builtins must always have a non-paired $ to avoid a clash.

[floitsch, 2012-02-24 20:50:33]

Should have caught that.
thanks for spotting.

On 2012/02/24 19:36:07, sra1 wrote:
> This is a broken fix.
> 
> The Frog name mangling rule is that $ in a user identifier is always
doubled-up
> to $$.
> I think you could write this in Dart and get a clash:
>    void $eq(){}
> 
> The $-->$$ mangling means
>   (1) a single $ is always safe for a non-user identifier (like builtings and
> argument defaulting trampoline),
>   (2) builtins must always have a non-paired $ to avoid a clash.