Issue 9447018: Add -ldl linker flag to libdart_builtin link step.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9447018: Add -ldl linker flag to libdart_builtin link step. (Closed)

Created:
8 years, 10 months ago by Bill Hesse

Modified:
8 years, 10 months ago

Reviewers:
Anders Johnsen, Mads Ager (google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add -ldl linker flag to libdart_builtin link step. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4532

Patch Set 2 : Add linker flag only to linux build. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	runtime/bin/bin.gypi	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

lgtm, if we use gcc on windows. https://chromiumcodereview.appspot.com/9447018/diff/1/runtime/bin/bin.gypi File runtime/bin/bin.gypi (right): https://chromiumcodereview.appspot.com/9447018/diff/1/runtime/bin/bin.gypi#newcode223 runtime/bin/bin.gypi:223: 'ldflags': [ ...

8 years, 10 months ago (2012-02-23 14:10:39 UTC) #2

Bill Hesse

https://chromiumcodereview.appspot.com/9447018/diff/1/runtime/bin/bin.gypi File runtime/bin/bin.gypi (right): https://chromiumcodereview.appspot.com/9447018/diff/1/runtime/bin/bin.gypi#newcode223 runtime/bin/bin.gypi:223: 'ldflags': [ On 2012/02/23 14:10:39, ajohnsen wrote: > Win32? ...

8 years, 10 months ago (2012-02-23 14:20:13 UTC) #3

lgtm

Expand Messages | Collapse Messages

Issue 9447018: Add -ldl linker flag to libdart_builtin link step. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add linker flag only to linux build. #

Messages