Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 9433041: Change CodeAfterTryIsExecutedNegativeTest to a multitest. (Closed)

Created:
8 years, 10 months ago by ngeoffray
Modified:
8 years, 10 months ago
Reviewers:
ahe, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change CodeAfterTryIsExecutedNegativeTest to a multitest. Committed: https://code.google.com/p/dart/source/detail?r=4470

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M dart/tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download
D dart/tests/language/src/CodeAfterTryIsExecutedNegativeTest.dart View 1 chunk +0 lines, -14 lines 0 comments Download
A + dart/tests/language/src/CodeAfterTryIsExecutedTest.dart View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ngeoffray
8 years, 10 months ago (2012-02-22 15:08:33 UTC) #1
kasperl
I think we should try to avoid using negative or multi-test for things we can ...
8 years, 10 months ago (2012-02-22 16:51:08 UTC) #2
ahe
LGTM! https://chromiumcodereview.appspot.com/9433041/diff/1/dart/tests/language/src/CodeAfterTryIsExecutedTest.dart File dart/tests/language/src/CodeAfterTryIsExecutedTest.dart (right): https://chromiumcodereview.appspot.com/9433041/diff/1/dart/tests/language/src/CodeAfterTryIsExecutedTest.dart#newcode13 dart/tests/language/src/CodeAfterTryIsExecutedTest.dart:13: throw 'foo'; /// 01: runtime error On 2012/02/22 ...
8 years, 10 months ago (2012-02-22 16:54:09 UTC) #3
ngeoffray
8 years, 10 months ago (2012-02-22 16:57:18 UTC) #4
Thanks Kasper and Peter for taking a look.

https://chromiumcodereview.appspot.com/9433041/diff/1/dart/tests/language/src...
File dart/tests/language/src/CodeAfterTryIsExecutedTest.dart (right):

https://chromiumcodereview.appspot.com/9433041/diff/1/dart/tests/language/src...
dart/tests/language/src/CodeAfterTryIsExecutedTest.dart:13: throw 'foo'; /// 01:
runtime error
On 2012/02/22 16:54:09, ahe wrote:
> On 2012/02/22 16:51:08, kasperl wrote:
> > Why do you need this to be a negative test in the first place? Couldn't you
> > rename main to test and do like this:
> > 
> >    main() {
> >      Expect.throws(test);
> >    }
> 
> What this is testing breaks Expect.throws ;-)

I added a comment at the top of the file.

Powered by Google App Engine
This is Rietveld 408576698