Add both sync and async methods for getting streams for a File

Add both sync and async methods for getting streams for a File

The File class used to have two synchronous methods
openInputStream and openOutputStream for getting streams for a
file. These have now been changed to work asynchronously by the
associated callback inputStreamHandler or outputStreamHandler
when the stream is opened and available.

To support the synchronous API two new methods
openInputStreamSync and openOutputStreamSync which returns the
stream directly as before have been added.

The actual implemnetation of the file streams still uses the
synchronous file API internally. However this change
adds "simulated" handling of noPendingWriteHandler and
closeHandler for file output stream.

R=ager@google.com

BUG=dart:1784
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=4452

[Mads Ager (google), 2012-02-22 13:20:20]

LGTM with a couple of comments.

https://chromiumcodereview.appspot.com/9432023/diff/1/runtime/bin/file.dart
File runtime/bin/file.dart (right):

https://chromiumcodereview.appspot.com/9432023/diff/1/runtime/bin/file.dart#n...
runtime/bin/file.dart:129: * then the input stream itself will be asynchronous
as is the case
is synchronous then the ... will be ..
=>
is synchronous the ... is ...

https://chromiumcodereview.appspot.com/9432023/diff/1/runtime/bin/file.dart#n...
runtime/bin/file.dart:159: * then the output stream itself will be asynchronous
as is the case
Ditto.

https://chromiumcodereview.appspot.com/9432023/diff/1/tests/standalone/src/Fi...
File tests/standalone/src/FileInputStreamTest.dart (right):

https://chromiumcodereview.appspot.com/9432023/diff/1/tests/standalone/src/Fi...
tests/standalone/src/FileInputStreamTest.dart:116:
//testStringInputStreamAsync("readline_test1.dat", 111);
Accidental edit?

https://chromiumcodereview.appspot.com/9432023/diff/1/tests/standalone/src/Fi...
File tests/standalone/src/FileOutputStreamTest.dart (right):

https://chromiumcodereview.appspot.com/9432023/diff/1/tests/standalone/src/Fi...
tests/standalone/src/FileOutputStreamTest.dart:38: tempDirectory.deleteSync();
This really should be an async call. In fact, shouldn't this throw an exception
since you have used async methods on this directory object?

https://chromiumcodereview.appspot.com/9432023/diff/1/tests/standalone/src/Fi...
tests/standalone/src/FileOutputStreamTest.dart:69: tempDirectory.deleteSync();
Ditto.

https://chromiumcodereview.appspot.com/9432023/diff/1/tools/testing/dart/stat...
File tools/testing/dart/status_file_parser.dart (right):

https://chromiumcodereview.appspot.com/9432023/diff/1/tools/testing/dart/stat...
tools/testing/dart/status_file_parser.dart:62: // TODO(XXX): When the checked in
binary is updated to include the
Will you do this as part of committing this?

[Søren Gjesse, 2012-02-22 14:03:18]

https://chromiumcodereview.appspot.com/9432023/diff/1/runtime/bin/file.dart
File runtime/bin/file.dart (right):

https://chromiumcodereview.appspot.com/9432023/diff/1/runtime/bin/file.dart#n...
runtime/bin/file.dart:129: * then the input stream itself will be asynchronous
as is the case
On 2012/02/22 13:20:20, Mads Ager wrote:
> is synchronous then the ... will be ..
> =>
> is synchronous the ... is ...

Done.

https://chromiumcodereview.appspot.com/9432023/diff/1/runtime/bin/file.dart#n...
runtime/bin/file.dart:159: * then the output stream itself will be asynchronous
as is the case
On 2012/02/22 13:20:20, Mads Ager wrote:
> Ditto.

Done.

https://chromiumcodereview.appspot.com/9432023/diff/1/tests/standalone/src/Fi...
File tests/standalone/src/FileInputStreamTest.dart (right):

https://chromiumcodereview.appspot.com/9432023/diff/1/tests/standalone/src/Fi...
tests/standalone/src/FileInputStreamTest.dart:116:
//testStringInputStreamAsync("readline_test1.dat", 111);
On 2012/02/22 13:20:20, Mads Ager wrote:
> Accidental edit?

Yes.

https://chromiumcodereview.appspot.com/9432023/diff/1/tests/standalone/src/Fi...
File tests/standalone/src/FileOutputStreamTest.dart (right):

https://chromiumcodereview.appspot.com/9432023/diff/1/tests/standalone/src/Fi...
tests/standalone/src/FileOutputStreamTest.dart:38: tempDirectory.deleteSync();
On 2012/02/22 13:20:20, Mads Ager wrote:
> This really should be an async call. In fact, shouldn't this throw an
exception
> since you have used async methods on this directory object?

Fixed, Directory does not check mixed sync/async - filed 1796.

https://chromiumcodereview.appspot.com/9432023/diff/1/tests/standalone/src/Fi...
tests/standalone/src/FileOutputStreamTest.dart:69: tempDirectory.deleteSync();
On 2012/02/22 13:20:20, Mads Ager wrote:
> Ditto.

Done.

https://chromiumcodereview.appspot.com/9432023/diff/1/tools/testing/dart/stat...
File tools/testing/dart/status_file_parser.dart (right):

https://chromiumcodereview.appspot.com/9432023/diff/1/tools/testing/dart/stat...
tools/testing/dart/status_file_parser.dart:62: // TODO(XXX): When the checked in
binary is updated to include the
On 2012/02/22 13:20:20, Mads Ager wrote:
> Will you do this as part of committing this?

No, I would rather postpone until after finishing porting to native ports. Filed
1797 and changed XXX to 1797.