Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 9432022: Make sure the merge block after a try/catch has its dominator the block that contains HTry. This wa… (Closed)

Created:
8 years, 10 months ago by ngeoffray
Modified:
8 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, karlklose, ahe, kasperl, Lasse Reichstein Nielsen
Visibility:
Public.

Description

Make sure the merge block after a try/catch has its dominator the block that contains HTry. This way, the codegen does not think a catch block needs to visit the merge block. Committed: https://code.google.com/p/dart/source/detail?r=4447

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -26 lines) Patch
M frog/leg/ssa/builder.dart View 2 chunks +7 lines, -11 lines 0 comments Download
M frog/leg/ssa/codegen.dart View 1 chunk +3 lines, -1 line 0 comments Download
M frog/leg/ssa/nodes.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/co19/co19-leg.status View 1 6 chunks +9 lines, -2 lines 0 comments Download
M tests/corelib/corelib-leg.status View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/language/language-leg.status View 3 chunks +3 lines, -12 lines 0 comments Download
A tests/language/src/CodeAfterTryIsExecutedNegativeTest.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ngeoffray
8 years, 10 months ago (2012-02-22 12:04:27 UTC) #1
floitsch
8 years, 10 months ago (2012-02-22 12:54:05 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698