Issue 9431015: Wrote functions to convert collections and maps to strings and invoked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9431015: Wrote functions to convert collections and maps to strings and invoked (Closed)

Created:
8 years, 10 months ago by jjb

Modified:
8 years, 10 months ago

Reviewers:
cshapiro

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Wrote functions to convert collections and maps to strings and invoked these functions from the toString methods of all built-in Collection and Map implementations. Wrote smoke tests and basher tests. Committed: https://code.google.com/p/dart/source/detail?r=4421

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -148 lines)			Patch
A +	corelib/src/implementation/collections.dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	corelib/src/implementation/corelib_impl_sources.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	corelib/src/implementation/hash_map_set.dart	View		3 chunks	+9 lines, -1 line	0 comments	Download
M	corelib/src/implementation/linked_hash_map.dart	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	corelib/src/implementation/maps.dart	View		2 chunks	+52 lines, -1 line	0 comments	Download
M	corelib/src/implementation/queue.dart	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	corelib/src/implementation/splay_tree.dart	View		2 chunks	+5 lines, -1 line	0 comments	Download
D	frog/lib/collections.dart	View		1 chunk	+0 lines, -53 lines	0 comments	Download
M	frog/lib/corelib_impl.dart	View	1	5 chunks	+6 lines, -10 lines	0 comments	Download
M	frog/lib/frog_coreimpl_sources.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/lib/array.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/lib/arrays.dart	View		1 chunk	+1 line, -13 lines	0 comments	Download
M	runtime/lib/byte_array.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
D	runtime/lib/collections.dart	View		1 chunk	+0 lines, -52 lines	0 comments	Download
M	runtime/lib/growable_array.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/lib/immutable_map.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/lib/lib_impl_sources.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
A +	tests/corelib/src/CollectionToStringTest.dart	View		3 chunks	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages